From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5894046DFFF; Tue, 21 Jul 2026 18:51:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784659871; cv=none; b=S/KDJ4t2xgurFmPzSEgWLqY+C//wQ69NLaJ7W65xkxt+1MX6gliAOInnTbxla0lwvwQMdpjTbOZ9OuUuBZfAW8JZPfgIZtrnLKMw/5rqoz3xU2+jJstubigALIYm3/sVknAepc5u6TnvpnSTRjMXhUR2PCbuf83Y+WVomnmskhw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784659871; c=relaxed/simple; bh=Zf3aqnJTDU/RJhGYXd28BX1ZWMUM1RnWlq6w2qojD4k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lw02uzm2VFU6Oo2ElToja9wsfynzN7V0vEVTz0LU+tP5ctY19cFA+tR73WypvVhKSfiLLAy9HhayPr0qe80lg7Zl4Dcbf80uE4TAGbW7h5qP/0m3QxT2S7UWVigAi7L3UpHE8eG1Msg8o9d0Z4nQE76lJjarK1lV43t8ihTQTVE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=1xbqkErq; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="1xbqkErq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF6341F000E9; Tue, 21 Jul 2026 18:51:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784659868; bh=Yqh+7FiW0qS6OQ5V1ppUpJS+EJG4wfFLx2pqTXO0zaA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=1xbqkErqZlKaR6oOyeQ1VJlsO00NKsOqVGyLsl9NFHzL5WJTkBLtRGXWfYL1Ndw6a OF1R4OcZIFvHDLKn1UWCS8DROTMwAWEkzq7pLl6sH7AuTCX6+vclUfbKbA4exBoJiw uaoFoXIEll/lt9spx0LQkGNoQIbUuzRnbGE90YF0= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Grzegorz Nitka , Arkadiusz Kubalewski , Jakub Kicinski , Sasha Levin Subject: [PATCH 7.1 0763/2077] dpll: balance create/delete notifications in __dpll_pin_(un)register Date: Tue, 21 Jul 2026 17:07:16 +0200 Message-ID: <20260721152610.792328806@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152552.646164743@linuxfoundation.org> References: <20260721152552.646164743@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Grzegorz Nitka [ Upstream commit 1a2292101c0dc422466c673031de03d2e871adbe ] __dpll_pin_register() emits dpll_pin_create_ntf() internally, but __dpll_pin_unregister() left the matching delete to its callers. The counts then diverge on dpll_pin_on_pin_register() rollback and on dpll_pin_on_pin_unregister(), leaking stale notifications. Emit dpll_pin_delete_ntf() inside __dpll_pin_unregister() and drop the now-redundant call in dpll_pin_unregister(). Fixes: 9431063ad323 ("dpll: core: Add DPLL framework base functions") Signed-off-by: Grzegorz Nitka Reviewed-by: Arkadiusz Kubalewski Link: https://patch.msgid.link/20260607183045.1213735-8-grzegorz.nitka@intel.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/dpll/dpll_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dpll/dpll_core.c b/drivers/dpll/dpll_core.c index e3d7aeed43088f..8a8f2f4351235d 100644 --- a/drivers/dpll/dpll_core.c +++ b/drivers/dpll/dpll_core.c @@ -913,6 +913,7 @@ __dpll_pin_unregister(struct dpll_device *dpll, struct dpll_pin *pin, const struct dpll_pin_ops *ops, void *priv, void *cookie) { ASSERT_DPLL_PIN_REGISTERED(pin); + dpll_pin_delete_ntf(pin); dpll_xa_ref_pin_del(&dpll->pin_refs, pin, ops, priv, cookie); dpll_xa_ref_dpll_del(&pin->dpll_refs, dpll, ops, priv, cookie); if (xa_empty(&pin->dpll_refs)) { @@ -940,7 +941,6 @@ void dpll_pin_unregister(struct dpll_device *dpll, struct dpll_pin *pin, return; mutex_lock(&dpll_lock); - dpll_pin_delete_ntf(pin); __dpll_pin_unregister(dpll, pin, ops, priv, NULL); mutex_unlock(&dpll_lock); } -- 2.53.0