From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41743471264; Tue, 21 Jul 2026 18:56:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784660196; cv=none; b=N/YMi+AV/RT3QiI5cxcNraY7D4cP+aZ5p2cy8ZbPHDaNzU4kLPjLh0Oq2X8MtFxWTffkM+OeoJlSUYomUyVYfNJHFaou6aXPZPxkXRgsEgZL6z8X10i1K2tJZpyeka0X+1p6Vc+iQxdV1H6VsN6ULGPbYL81CfJ4xbLwyPW3Dzc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784660196; c=relaxed/simple; bh=lrajciwQ1zbPD0WOmfb56YCvtEbQ9AUxFdu+HLiYR6Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=i9hOlhIri0AiM8XhcsOedGK/YiVv3S6MmHooCLXNBOifvabTXkl2oE/u6+IWqPFc9sZh/ee0O5h/0S4ND0UOI5SubRUK18kldMnMt558qav3Nn1CyzYdGKEDWTxXx9+zM+aaaknMhezgzL1rlhUZowznEXNAGF/zaTUvhFbdWCw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=S0FQACUX; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="S0FQACUX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A816D1F000E9; Tue, 21 Jul 2026 18:56:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784660195; bh=fgn3DV7tSuLkTI0oFo6fwEC0BPbVf6wwBzaMlD31HUA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=S0FQACUXo+MabsEmvLLKKyeekVyDRNgj1eL47AyI+QRJKOYIdFFuf9+zZumP+8n9d 2oWtOJesmlAGH+kBuG9gbOMr9HZpVynOd/NtYjFwChRq8LbyAJQdcIeO0UVLAwStcB sgQ0SipKvPtuWJUKdp0KqUXFP7xooFGKvPk70sCI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Guangshuo Li , Sasha Levin Subject: [PATCH 7.1 0889/2077] staging: most: video: avoid double free on video register failure Date: Tue, 21 Jul 2026 17:09:22 +0200 Message-ID: <20260721152613.782063542@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152552.646164743@linuxfoundation.org> References: <20260721152552.646164743@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Guangshuo Li [ Upstream commit 7cb1c5b32a2bfde961fff8d5204526b609bcb30a ] comp_register_videodev() allocates a video_device with video_device_alloc() and releases it if video_register_device() fails. This can double free the video_device when __video_register_device() reaches device_register() and that call fails: video_register_device() -> __video_register_device() -> device_register() fails -> put_device(&vdev->dev) -> v4l2_device_release() -> vdev->release(vdev) -> video_device_release(vdev) comp_register_videodev() -> video_device_release(mdev->vdev) Use video_device_release_empty() while registering the device so that registration failure paths do not free mdev->vdev through vdev->release(). comp_register_videodev() then releases mdev->vdev exactly once on failure. Restore video_device_release() after successful registration so the registered device keeps its normal lifetime handling. This issue was found by a static analysis tool I am developing. Fixes: eab231c0398a ("staging: most: v4l2-aim: remove unnecessary label err_vbi_dev") Signed-off-by: Guangshuo Li Link: https://patch.msgid.link/20260517111218.945796-1-lgs201920130244@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/staging/most/video/video.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/staging/most/video/video.c b/drivers/staging/most/video/video.c index 04351f8ccccf17..aab57768f4f707 100644 --- a/drivers/staging/most/video/video.c +++ b/drivers/staging/most/video/video.c @@ -420,6 +420,7 @@ static int comp_register_videodev(struct most_video_dev *mdev) /* Fill the video capture device struct */ *mdev->vdev = comp_videodev_template; + mdev->vdev->release = video_device_release_empty; mdev->vdev->v4l2_dev = &mdev->v4l2_dev; mdev->vdev->lock = &mdev->lock; snprintf(mdev->vdev->name, sizeof(mdev->vdev->name), "MOST: %s", @@ -432,9 +433,13 @@ static int comp_register_videodev(struct most_video_dev *mdev) v4l2_err(&mdev->v4l2_dev, "video_register_device failed (%d)\n", ret); video_device_release(mdev->vdev); + return ret; } - return ret; + mdev->vdev->release = video_device_release; + + return 0; + } static void comp_unregister_videodev(struct most_video_dev *mdev) -- 2.53.0