From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5758471264; Tue, 21 Jul 2026 18:56:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784660212; cv=none; b=pmEPV+tMSewVoc0nQYIm1G5269vEVbtsf3ymJzxh7fuqX/NJMNJpJqQnn86ZLymR4TYwmHefxirxFM2LwdBMdn8lXxwh25oxzYbCseN0yN1stPTfZ5bzwiVM8im9dhOhA9x/vwljsCUE2uNA6nJpDahXYnPCJpRg9nscXA5DzrE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784660212; c=relaxed/simple; bh=b5bMvusSPE9pHna3htNJOm6xvSTJvhP3MMAVcdd5YZw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aTabkXb4byxP/HnT+HTBKIDSMW43LhSlVcazGA+k+iruW7EZoaBMJ8mdM0DFdid7JY3wjpNHJHlZTlqHgWP7jS2verNREuQqGGvX9F1cVM2zX5ZUISQo7TyFd+zfA0tQY/h/cixFOrWPhlAELnhvhCSHviR9t4AL+K3BQmiXH/w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=b+p4T5ow; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="b+p4T5ow" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46F541F000E9; Tue, 21 Jul 2026 18:56:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1784660210; bh=3ua5Eelmg2CFtLEUMDsbicjAe+jfmnpF6sWpDO3TrhU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=b+p4T5owAuwGqRVkYgpEfsaAw7Zpa2oLaIjtSVxWfEjUxMqxW9jaJa5PlKuCUOKUy A8oAQGnqQJ3+gw9qbJ+td/OmleS+ewFwyoBIzAFxdFE0vzdTdGB7p4szMV0vUuzN74 1/OFn5pYTW3Ef64P64HZQ3dUWnZqqEW+hDTB/mPw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, James Kim , Sasha Levin Subject: [PATCH 7.1 0894/2077] char: tlclk: fix use-after-free in tlclk_cleanup() Date: Tue, 21 Jul 2026 17:09:27 +0200 Message-ID: <20260721152613.903167525@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260721152552.646164743@linuxfoundation.org> References: <20260721152552.646164743@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: James Kim [ Upstream commit bbf003b7794d6ad6f939fdd29f1f1bde8ac554c1 ] This patch improves the module cleanup process in the tlclk driver to prevent potential use-after-free and race conditions. Currently, the file_operations structure does not specify the .owner field, which could allow the module to be unloaded while user-space processes are still interacting with the device. Additionally, the tlclk_cleanup() function frees the alarm_events memory before ensuring that blocked processes in the waitqueue are fully awakened and that the switchover_timer has completed. To address these cases, this patch: - Sets '.owner = THIS_MODULE' in tlclk_fops to safely defer module unloading while the device is in use. - Updates tlclk_cleanup() to explicitly wake up all blocked readers (wake_up_all), properly release hardware I/O regions, and safely delete the timer (timer_delete_sync) prior to freeing memory. Fixes: 1a80ba882730 ("[PATCH] Telecom Clock Driver for MPCBL0010 ATCA computer blade") Signed-off-by: James Kim Link: https://patch.msgid.link/20260503101131.64219-1-james010kim@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/char/tlclk.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/char/tlclk.c b/drivers/char/tlclk.c index 677d230a226cf5..dd45fe5eb6f270 100644 --- a/drivers/char/tlclk.c +++ b/drivers/char/tlclk.c @@ -264,6 +264,7 @@ static ssize_t tlclk_read(struct file *filp, char __user *buf, size_t count, } static const struct file_operations tlclk_fops = { + .owner = THIS_MODULE, .read = tlclk_read, .open = tlclk_open, .release = tlclk_release, @@ -837,6 +838,9 @@ static void __exit tlclk_cleanup(void) misc_deregister(&tlclk_miscdev); unregister_chrdev(tlclk_major, "telco_clock"); + got_event = 1; + wake_up_all(&wq); + release_region(TLCLK_BASE, 8); timer_delete_sync(&switchover_timer); kfree(alarm_events); -- 2.53.0