From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: Sasha Levin <sashal@kernel.org>,
harshit.m.mogalapalli@oracle.com, stable@vger.kernel.org,
patches@lists.linux.dev, Yun Zhou <yun.zhou@windriver.com>
Subject: Re: [PATCH 6.12.y] ext4: validate donor file superblock early in EXT4_IOC_MOVE_EXT
Date: Sun, 26 Jul 2026 08:04:44 -0400 [thread overview]
Message-ID: <20260725192000.stable-0005@kernel.org> (raw)
In-Reply-To: <20260724143828.1668805-1-yun.zhou@windriver.com>
> commit c143957520c6c9b5cd72e0de8b52b814f0c576fe upstream.
Thanks Yun, and thanks Harshit for spotting the donor-fd leak.
Since the original backport is already queued, the cleanest thing is an
incremental fixup on top rather than a full replacement (which just
duplicates the merged commit). In 6.12 the fix is to turn the early
"return -EXDEV;" into "err = -EXDEV; goto mext_out;" so the fdput(donor)
cleanup at the mext_out label is not bypassed. Could you send that
one-line delta and I will apply it? Thanks.
--
Thanks,
Sasha
next prev parent reply other threads:[~2026-07-26 12:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 14:38 [PATCH 6.12.y] ext4: validate donor file superblock early in EXT4_IOC_MOVE_EXT Yun Zhou
2026-07-24 15:26 ` Greg KH
2026-07-25 2:43 ` Zhou, Yun
2026-07-25 5:18 ` Greg KH
2026-07-26 12:04 ` Sasha Levin [this message]
2026-07-26 12:56 ` Zhou, Yun
2026-07-26 21:24 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260725192000.stable-0005@kernel.org \
--to=sashal@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=patches@lists.linux.dev \
--cc=stable@vger.kernel.org \
--cc=yun.zhou@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox