From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6222C38C426; Thu, 30 Jul 2026 16:00:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785427256; cv=none; b=cLr84R2W9GyZeOZm78CgXYzk5ELgKyu2cWEdbDGekpJqIiHutgrbvxEeTToLttBQ//xWQ3tK9tWwYiZcOzVuQH5Du4vXB1A2MeNGp0KxysQVv3m0vjr5uHp7NwFq+dMkUu1QW7rwIZoKQaz+HPDJKFHhManoYLkCZhzNvPoAc2A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785427256; c=relaxed/simple; bh=3Ed9iOyeM5Xhc35btZmBvW3u58ArCrSkhtSk65o0fl0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=q1zOiqc+R7WLBliOxjHJzapMibIKn40Uht+cDEoLLnD6RyQSrdpkLuRzoGVb3exoaw/t5A4jYfmMNB7syLTVYG8f/5viuA0jlsFx9svtwt0yHAhHJNKFAEPB7NW+faUKz+cIX+daIfmiaUCg3+DGs45SRBVv1G/cya/K7VPR2lE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Oe2oalgb; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Oe2oalgb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 532D21F00ACA; Thu, 30 Jul 2026 16:00:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1785427254; bh=HDPM3DTH+FNPv2t2YgXpKAxQnzDDa2WXBvr3bjNOriU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Oe2oalgbdHcu9vO1z4/qnO5tgee3BMAKipr+eE/jd17v7/mD6yBjbnnWhVSnCIsv/ 5/PtGlF6bJeREcgXDRXAE5RKn7jyDCe7wiGxFXNBvdBGyFXZbi0RGs+oRHH8AaU73P XQxCBlzxVL0/mVl0msYiFEOwbOJKwmgIITff3TRY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable , Muhammad Bilal Subject: [PATCH 6.6 106/484] usb: gadget: uvc: clamp SEND_RESPONSE length to the response buffer Date: Thu, 30 Jul 2026 16:10:03 +0200 Message-ID: <20260730141425.762431979@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260730141423.392222816@linuxfoundation.org> References: <20260730141423.392222816@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Muhammad Bilal commit b70dc75e85ba968b7b76eebfe5d63000080b875b upstream. uvc_send_response() builds the UVC control response from a user-supplied struct uvc_request_data: req->length = min_t(unsigned int, uvc->event_length, data->length); ... memcpy(req->buf, data->data, req->length); req->length is clamped to uvc->event_length, which is taken from the host control request wLength (up to UVC_MAX_REQUEST_SIZE, 64), and to data->length, which comes from the UVCIOC_SEND_RESPONSE ioctl and is only checked for being negative. The source buffer data->data is only 60 bytes, so a response with uvc->event_length and data->length both greater than 60 makes memcpy() read past the end of data->data. Clamp req->length to sizeof(data->data) as well. Fixes: a5eaaa1f33e7 ("usb: gadget: uvc: use capped length value") Cc: stable Signed-off-by: Muhammad Bilal Link: https://patch.msgid.link/20260629195004.148405-1-meatuni001@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Greg Kroah-Hartman --- drivers/usb/gadget/function/uvc_v4l2.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/usb/gadget/function/uvc_v4l2.c +++ b/drivers/usb/gadget/function/uvc_v4l2.c @@ -191,6 +191,8 @@ uvc_send_response(struct uvc_device *uvc return usb_ep_set_halt(cdev->gadget->ep0); req->length = min_t(unsigned int, uvc->event_length, data->length); + if (req->length > sizeof(data->data)) + req->length = sizeof(data->data); req->zero = data->length < uvc->event_length; memcpy(req->buf, data->data, req->length);