From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16F99449B3E; Thu, 30 Jul 2026 16:03:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785427415; cv=none; b=V4TkV/TLpqvPxzzCjFPrf3tAsN3suk8JCOmb5ELKe1PUriqMZJ/eHzy+LVtnqKZmX10V4wQGS/vqvMT9pIwguh/Ww8iHFGlDCXAnOOtZo8Kc09WDC85R9Tl8wWCjnsiSu4TAGXgqXrjtE03iVT5YzR49l82LZojPjBn+JVaq2Uk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785427415; c=relaxed/simple; bh=s2VPI4ZL6fWkYMQrQKjvsAezjPbpego+/OVK7vqroU4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Lgh3gfXJ8/336eLFmpjkE1urfkjD6cygfk8gi74tKt3HzZa2HTTRVSR2OB144nvjPMBI4KZswPcI7q29QECjCT4GpazfOBmXEAA66w5kMgMIYPCceFtH6adY4AE96O9Hk2Izkx02VAIz303+WZsTxDGXa8G8RnTLqCTm5ldaIZM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=BAFKRi9N; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="BAFKRi9N" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72B171F00A3E; Thu, 30 Jul 2026 16:03:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1785427414; bh=LA+9C2qchqa8JjC0ExLZ7YuiNyKdQ/kcRlnXasAtbJU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=BAFKRi9N5jg9fSmrt6ytoPVqTeynAeVM1qtsi36Q0S3eOjIg4D0lfuv4W4DI4zbIZ BYO+C9oYGvvkwpM2L2CGiDGeTiobiQsURM8LU6F3hgK0FcZcNm/+PEg0B2S/rhMN9A Hi2XqjwOl1e2a4AO1w3kL5bJNVs9nFSpSPbiRkng= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, HanQuan , Xin Long , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.6 161/484] sctp: fix auth_chunk_list capacity check in sctp_auth_ep_add_chunkid Date: Thu, 30 Jul 2026 16:10:58 +0200 Message-ID: <20260730141426.964797076@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260730141423.392222816@linuxfoundation.org> References: <20260730141423.392222816@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: HanQuan [ Upstream commit ff04b26794a16a8a879eb4fd2c02c2d6b03850e9 ] sctp_auth_ep_add_chunkid() uses SCTP_NUM_CHUNK_TYPES (20) as the capacity limit for ep->auth_chunk_list, allowing it to hold up to 20 chunk entries (param_hdr.length up to 24). However, the copy destination asoc->c.auth_chunks in struct sctp_cookie is only SCTP_AUTH_MAX_CHUNKS (16) entries (20 bytes). When more than 16 chunks are added, sctp_association_init() memcpy overflows the destination by up to 4 bytes. Fix by using SCTP_AUTH_MAX_CHUNKS as the capacity limit, matching the destination capacity. Fixes: 1f485649f529 ("[SCTP]: Implement SCTP-AUTH internals") Signed-off-by: HanQuan Acked-by: Xin Long Link: https://patch.msgid.link/20260713032021.3491702-1-zhoujian.zja@antgroup.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- net/sctp/auth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sctp/auth.c b/net/sctp/auth.c index c58fffc86a0c2d..8320764b16b928 100644 --- a/net/sctp/auth.c +++ b/net/sctp/auth.c @@ -766,7 +766,7 @@ int sctp_auth_ep_add_chunkid(struct sctp_endpoint *ep, __u8 chunk_id) /* Check if we can add this chunk to the array */ param_len = ntohs(p->param_hdr.length); nchunks = param_len - sizeof(struct sctp_paramhdr); - if (nchunks == SCTP_NUM_CHUNK_TYPES) + if (nchunks == SCTP_AUTH_MAX_CHUNKS) return -EINVAL; p->chunks[nchunks] = chunk_id; -- 2.53.0