From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 343DD3911CA; Thu, 30 Jul 2026 16:07:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785427631; cv=none; b=I8lzNfKaBcOKF3TImmkNxypbNYplFAE2tKgk/IdcYDHzVG4tPF57DM5f8cnzfmRe6tBVCXkOy7KmGJpSjRJQ93sTH9EPzNeFOjLY0bIM+8eIsPCGmQd9lTdUcLoTl5+uqsotQwo3dsGVcn3wuMyNFLjotBFE8C1v49ysSIV+a9E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785427631; c=relaxed/simple; bh=LlfGGxHd3L9QmdF4AJA/g6uveDrDb3QPD6LzvNwpu30=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=q+cdV7u+8TClj5fFlLYyhZHWU/p4TYqbD/taPxGuKaaXJOuttkFdBwDv7ZtpjDrKK6JmY7x7s7BmbFjPIG5adS5XkRzVkyzSSYcD5ILK3GKY+VULpv1lHM8lb3CN9wxU9HY8NOkQlSXSBONrnEKItJtl6TjwFgSExtmagr9TbYM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=n03obFI2; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="n03obFI2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B92C1F000E9; Thu, 30 Jul 2026 16:07:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1785427630; bh=cYkq+AAt9ZnEdtTLBcB9dYkp3Ja2o0KFpoBKLKqiFDs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=n03obFI2u7Gf35dYezFOx2YlHvOyr/91AbkNnBIsuWuDyVlW2pqlKd8qpylld1JF6 6SuQLgdCB7L+es48GvARnKz/Xl0US717n1y4VWDFGSQLG+qrEODP4nuB8kvPae6UR5 MDbUxyORzzS1OpSrpH7x23+0IQuYQsNGOmF/DDBk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Pengpeng Hou , Nicolas Dufresne , Jernej Skrabec , Chen-Yu Tsai , Hans Verkuil Subject: [PATCH 6.6 239/484] media: cedrus: skip invalid H.264 reference list entries Date: Thu, 30 Jul 2026 16:12:16 +0200 Message-ID: <20260730141428.671517113@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260730141423.392222816@linuxfoundation.org> References: <20260730141423.392222816@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Pengpeng Hou commit 10358ea986c3c85516d1c8206486464f79d36e76 upstream. Cedrus consumes H.264 ref_pic_list0/ref_pic_list1 entries from the stateless slice control and later uses their indices to look up decode->dpb[] in _cedrus_write_ref_list(). Rejecting such controls in cedrus_try_ctrl() would break existing userspace, since stateless H.264 reference lists may legitimately carry out-of-range indices for missing references. Instead, guard the actual DPB lookup in Cedrus and skip entries whose indices do not fit the fixed V4L2_H264_NUM_DPB_ENTRIES array. This keeps the fix local to the driver use site and avoids out-of-bounds reads from malformed or unsupported reference list entries. Fixes: e000e1fa4bdbd ("media: uapi: h264: Update reference lists") Cc: stable@vger.kernel.org Signed-off-by: Pengpeng Hou Reviewed-by: Nicolas Dufresne Acked-by: Jernej Skrabec Tested-by: Chen-Yu Tsai Signed-off-by: Nicolas Dufresne Signed-off-by: Hans Verkuil Signed-off-by: Greg Kroah-Hartman --- drivers/staging/media/sunxi/cedrus/cedrus_h264.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/staging/media/sunxi/cedrus/cedrus_h264.c +++ b/drivers/staging/media/sunxi/cedrus/cedrus_h264.c @@ -210,6 +210,9 @@ static void _cedrus_write_ref_list(struc u8 dpb_idx; dpb_idx = ref_list[i].index; + if (dpb_idx >= V4L2_H264_NUM_DPB_ENTRIES) + continue; + dpb = &decode->dpb[dpb_idx]; if (!(dpb->flags & V4L2_H264_DPB_ENTRY_FLAG_ACTIVE))