From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9EC832ED40; Thu, 30 Jul 2026 16:15:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785428160; cv=none; b=jVG9tGEE9K364Gex6f1NWEzWgU/P2I9eQH91Hp7TNnKmJH7nIMbYvdRyehcn8fpZnBFOng6WhDjiXtAvnl3An/aPoslUvdjC98erDZ2uwaHnEQdTW1Ft9JSWWWp5nnJjflIibaUsccDMUUXCxt6XuhnozV3/hSoQKv17pek6RcE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785428160; c=relaxed/simple; bh=hp5SHORdEFlHHYEa5l5vq/+rcR2nvm0IDAMuYX4KiA8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aW77TpxvZDu+95wunuisqkVJk/OJ9JyRiUR6HYYuPWTEgaJMFvdz2zarmK2txdE6XzEkNXrunQdeHJB5dld92LLKVTjrtQNXv+GAFh27uJaIxDKerVFf3VvBsqj3h1B5ZG2HXngm3COzSlqPo2tkVlXkFfSXDdDxVsnJk2hUeNM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=XMMBv6IP; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="XMMBv6IP" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4D201F00A3F; Thu, 30 Jul 2026 16:15:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1785428153; bh=vQ1byTAcuKGcO5peYt82K35vwyNdes8rJKao9p5mo7k=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=XMMBv6IPG+gDoblJg3slfxRbfEGu9QhKDK+CikODmF0C0BQ/8ZHqEzGxAOz0O5KhN LvqzusPo5ZnQyqilqP9zOUm7SyQs6StY9NAWoi/mP24/eaATHACT6v+Y3S+8l3JOHt Ar1RBOvfn7wCSmAOgXmr5rUJb+RLO1Flr3kL/w3g= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Haoxiang Li , Bartosz Golaszewski , Andi Shyti , Sasha Levin Subject: [PATCH 6.6 368/484] i2c: davinci: Unregister cpufreq notifier on probe failure Date: Thu, 30 Jul 2026 16:14:25 +0200 Message-ID: <20260730141431.469405253@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260730141423.392222816@linuxfoundation.org> References: <20260730141423.392222816@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Haoxiang Li [ Upstream commit e43f32816a1b1fe5a86279411626fe3a9be56d45 ] davinci_i2c_probe() registers a cpufreq transition notifier before adding the I2C adapter. If i2c_add_numbered_adapter() fails, the probe error path releases the device resources without unregistering the notifier. Add a dedicated error path to unregister the cpufreq notifier after i2c_add_numbered_adapter() fails. Fixes: 82c0de11b734 ("i2c: davinci: Add cpufreq support") Signed-off-by: Haoxiang Li Cc: # v2.6.36+ Reviewed-by: Bartosz Golaszewski Signed-off-by: Andi Shyti Link: https://lore.kernel.org/r/20260610030513.2651018-1-haoxiang_li2024@163.com Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/i2c/busses/i2c-davinci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/i2c/busses/i2c-davinci.c +++ b/drivers/i2c/busses/i2c-davinci.c @@ -866,13 +866,15 @@ static int davinci_i2c_probe(struct plat adap->nr = pdev->id; r = i2c_add_numbered_adapter(adap); if (r) - goto err_unuse_clocks; + goto err_cpufreq; pm_runtime_mark_last_busy(dev->dev); pm_runtime_put_autosuspend(dev->dev); return 0; +err_cpufreq: + i2c_davinci_cpufreq_deregister(dev); err_unuse_clocks: pm_runtime_dont_use_autosuspend(dev->dev); pm_runtime_put_sync(dev->dev);