From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A891D43F09F; Thu, 30 Jul 2026 14:22:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785421379; cv=none; b=kn50hGrVkJgw8APloFuiPVNJHCZvbQNbfDEGlfztDs2qzp94gDq+kU9Kw1WYClcYSx2w0F1RyP16bDfoA2OXvkLUcEq8dSgTxY9qEFtCUvA6fvXrssC01AbcHGXLbF+xSDdIJMZfLNGLii6EOgJ0UovkmRhGmvuv1mh+twEHHZM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785421379; c=relaxed/simple; bh=HTfemGmHqaCV0rh8F3VqH4L91hMntHiU0c/hfTTPecA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=m+Xx8wM1junPIWVSiSBhDKrDL1VBOWczxTgNs4AoH3N6Jvzec+KCY5QdPivh14OEVxKCr3El2FatJ7//QkLku8GtvLqmr3Di9ORo/2fyoIZ8+2uXhL3eWMHLyugR5xUwWUpGx2resa/NrdDEDwJxcPLUFduPDiN0BCHJ3Ev+Lbo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=RxyprWsm; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="RxyprWsm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DEF461F000E9; Thu, 30 Jul 2026 14:22:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1785421377; bh=lkdIXa1bEbyWThaM2Lwe7xYC4RLMD67xGBVi3Qwn9Tg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=RxyprWsmYE/dZC/Zm7O94lSBRTL9M+GEa/owN6rim1F+AMuxf2GtY9FoSSwjJlN4U VFJI9KXhIrTbtNuYZsh6MX+GIMaEHeJoVOsR1vQ7adtf7S4YzKe+bDWfynerPi3jhd toiwNqdx8pufYIDfXNNRStILa6wnP5M87GvIg64c= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Danila Chernetsov , Junxian Huang , Jason Gunthorpe , Sasha Levin Subject: [PATCH 7.1 039/744] RDMA/hns: Fix potential integer overflow in mhop hem cleanup Date: Thu, 30 Jul 2026 16:05:12 +0200 Message-ID: <20260730141445.113430924@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260730141444.267951807@linuxfoundation.org> References: <20260730141444.267951807@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Danila Chernetsov [ Upstream commit 9f0f2d2121f16d420199a82ac5bbc242269133b3 ] In hns_roce_cleanup_mhop_hem_table(), the expression: obj = i * buf_chunk_size / table->obj_size; is evaluated using 32-bit unsigned arithmetic because 'buf_chunk_size' is u32 and the usual arithmetic conversions convert 'i' to unsigned int. The result is assigned to a u64 variable, but the multiplication may overflow before the assignment. For sufficiently large HEM tables, this produces an incorrect object index passed to hns_roce_table_mhop_put(). Cast 'i' to u64 before the multiplication so that the intermediate calculation is performed with 64-bit arithmetic. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: a25d13cbe816 ("RDMA/hns: Add the interfaces to support multi hop addressing for the contexts in hip08") Link: https://patch.msgid.link/r/20260627095951.51378-1-listdansp@mail.ru Signed-off-by: Danila Chernetsov Reviewed-by: Junxian Huang Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/hw/hns/hns_roce_hem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/hns/hns_roce_hem.c b/drivers/infiniband/hw/hns/hns_roce_hem.c index ccb40f8a48b726..a38bfd9a0fe243 100644 --- a/drivers/infiniband/hw/hns/hns_roce_hem.c +++ b/drivers/infiniband/hw/hns/hns_roce_hem.c @@ -836,7 +836,7 @@ static void hns_roce_cleanup_mhop_hem_table(struct hns_roce_dev *hr_dev, mhop.bt_chunk_size; for (i = 0; i < table->num_hem; ++i) { - obj = i * buf_chunk_size / table->obj_size; + obj = (u64)i * buf_chunk_size / table->obj_size; if (table->hem[i]) hns_roce_table_mhop_put(hr_dev, table, obj, 0); } -- 2.53.0