From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1B67633D4E2; Thu, 30 Jul 2026 14:27:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785421659; cv=none; b=eAKovawXgrdkqDPiWbUrRdiFijDgcv7QuS8QWNOpZqOgdKffIcGXT3nVJzuUVib1KLI4nJALZKkNYIvtp4ZC/dnwoKIIbaNVvvwOREAH/fbf6VZ1BmehnHPncDkBnUJWe1PPAfOr7wj/gyyqtdWZlNshEpXkRg8rG3z9vA3GvXk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785421659; c=relaxed/simple; bh=VUANGczzPCyhVgeCsQEnJp0PQUcgtWTNl6DbixZfBUs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=S7VrELOAXfNw5NgfC+NpD19k3dzBH6prHv39qOQ/1pRu1qFTzBUjQnZ3V/35vuIQqm9xGm+YuQTJUTi4yolnnL3KLsAkeRH1Nox02dovYW0MvbrU40zWPsH6TlkM/ZPtESZXslUjX10z8Iuw6w38Mgqi2Hcu71RNwhYbIyuj+QU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=m8mcBJoX; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="m8mcBJoX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6830F1F00A3A; Thu, 30 Jul 2026 14:27:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1785421656; bh=x8ljCGDJL4vjQeVYtSpRx3XV9Un+JhoPuq2rY7EtVIw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=m8mcBJoXEafgpFFG3Go0AglrE/SpCNn+sax7S9qlyMp7+QEnK0oOm/cGhI9+sn9gm 124IiBAXxmSiFQlF8WieWSiGp2ia+9I7o2Hqp90fHjybSSUQbWI/zkKoKsOsliUJBa 5zYUF7OCYOgwxYauoRQG8QKYjDZowGWTqaBqqQOE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yuan Tan , Xin Liu , Zihan Xi , Ren Wei , Xin Long , Paolo Abeni , Sasha Levin Subject: [PATCH 7.1 133/744] sctp: fix auth_hmacs array size in struct sctp_cookie Date: Thu, 30 Jul 2026 16:06:46 +0200 Message-ID: <20260730141447.106127838@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260730141444.267951807@linuxfoundation.org> References: <20260730141444.267951807@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Xin Long [ Upstream commit e0b5252a59383b77d1b8dbeda00b7184dd95f4d3 ] The auth_hmacs array in struct sctp_cookie is supposed to store a complete SCTP_AUTH_HMAC_ALGO parameter, which consists of a struct sctp_paramhdr followed by N HMAC identifiers. However, the array size was calculated using an extra 2 bytes instead of sizeof(struct sctp_paramhdr), which is 4 bytes. When four HMAC identifiers are configured, the HMAC-ALGO parameter stored in the endpoint is larger than the auth_hmacs buffer in the cookie. As a result, sctp_association_init() copies beyond the end of auth_hmacs when initializing the association, corrupting the adjacent auth_chunks field. This can lead to an invalid HMAC identifier being accepted and later cause an out-of-bounds read in sctp_auth_get_hmac(). Fix the array size calculation by including the full SCTP parameter header size. Fixes: 1f485649f529 ("[SCTP]: Implement SCTP-AUTH internals") Reported-by: Yuan Tan Reported-by: Xin Liu Reported-by: Zihan Xi Reported-by: Ren Wei Signed-off-by: Xin Long Link: https://patch.msgid.link/634a0de0d5de29532915e6d47c92a0cbc206e03f.1783707155.git.lucien.xin@gmail.com Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- include/net/sctp/structs.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/net/sctp/structs.h b/include/net/sctp/structs.h index affee44bd38e31..cccc662561aac3 100644 --- a/include/net/sctp/structs.h +++ b/include/net/sctp/structs.h @@ -312,7 +312,8 @@ struct sctp_cookie { __u8 auth_random[sizeof(struct sctp_paramhdr) + SCTP_AUTH_RANDOM_LENGTH]; - __u8 auth_hmacs[SCTP_AUTH_NUM_HMACS * sizeof(__u16) + 2]; + __u8 auth_hmacs[sizeof(struct sctp_paramhdr) + + SCTP_AUTH_NUM_HMACS * sizeof(__u16)]; __u8 auth_chunks[sizeof(struct sctp_paramhdr) + SCTP_AUTH_MAX_CHUNKS]; /* This is a shim for my peer's INIT packet, followed by -- 2.53.0