From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0D1A2E9EC7; Thu, 30 Jul 2026 14:27:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785421666; cv=none; b=PTrxYpo7w1CKnwlPMDCWlSiAnOnfsfhCPcFPmCMzEunx3tY8vHSg6asi9zsTJn6moqrtIChJ88Ny4IKiRNkRax8Hdx/w9wXXYZJs9pABFtozlcYDaP9Ua3VypP61qt7MtaQTqjuQpUkIInbOKP1WpO7USQ2wFOitEv4hZR093wM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785421666; c=relaxed/simple; bh=5in1Mr7ufS1k1iyBvRM8WwwseD94CiuLy3+OZyFL/nU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CvWlz6c3+7rE5OYaQRET6NX59qxtNlKZDXyfrVa5oVl3r5bTIcnj0Fqt7K6tDPiLyK0iUPbCntJX6wjfFNZs54ZH4nUDgqFgFgfDSq9OWgWBHMTH6emNAJE/ejfVte8WCVBc/POumqjXo2cin/yI0WQgfVzhzDW2DILEwCvFKag= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=2DjqYUE0; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="2DjqYUE0" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D4571F000E9; Thu, 30 Jul 2026 14:27:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1785421664; bh=eLNspnBNYdggbsmGtOUgZcdL04A5HetPWKswFwoYPuI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=2DjqYUE0L6l40LyZiHKhyv8QPWvGy+xlt4SyGd8plRij1PxriTapXqx1b+Ernva1n QtXDu45e9OZV2/Vt4O5R9FnGFAzsRzn3NKzUK7PGcd7C9zdRgeGoDQoxFxZS0JuSiE Yf0Tjhc9AF9vVDdlafsQ6kSa92cx/xPRydRGchFY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Sashiko , Guenter Roeck , Sasha Levin Subject: [PATCH 7.1 173/744] hwmon: (gigabyte_waterforce) Stop device IO before calling hid_hw_stop Date: Thu, 30 Jul 2026 16:07:26 +0200 Message-ID: <20260730141447.965847025@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260730141444.267951807@linuxfoundation.org> References: <20260730141444.267951807@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Guenter Roeck [ Upstream commit ff0c5c53d08274e200b48a4d53aa078265e873cb ] Calling hid_hw_stop() does not stop the device IO. This results in a race condition between hid_input_report() and the point immediately following the execution of hid_device_io_start() within the driver probe function. If the probe operation fails after "io start" has been initiated, this race condition will result in a UAF vulnerability. Fix the problem by calling hid_device_io_stop() before calling hid_hw_stop(). Reported-by: Sashiko Fixes: 42ac68e3d4ba0 ("hwmon: Add driver for Gigabyte AORUS Waterforce AIO coolers") Signed-off-by: Guenter Roeck Signed-off-by: Sasha Levin --- drivers/hwmon/gigabyte_waterforce.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/hwmon/gigabyte_waterforce.c b/drivers/hwmon/gigabyte_waterforce.c index 27487e215bddff..4eea05f8b569c2 100644 --- a/drivers/hwmon/gigabyte_waterforce.c +++ b/drivers/hwmon/gigabyte_waterforce.c @@ -371,13 +371,15 @@ static int waterforce_probe(struct hid_device *hdev, const struct hid_device_id if (IS_ERR(priv->hwmon_dev)) { ret = PTR_ERR(priv->hwmon_dev); hid_err(hdev, "hwmon registration failed with %d\n", ret); - goto fail_and_close; + goto fail_and_io_stop; } waterforce_debugfs_init(priv); return 0; +fail_and_io_stop: + hid_device_io_stop(hdev); fail_and_close: hid_hw_close(hdev); fail_and_stop: -- 2.53.0