From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6B5F367B89; Thu, 30 Jul 2026 14:45:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785422715; cv=none; b=GhGBM8ZWdM5mgmkucOvtj2LqhqVt4QItSy/DE+nZ2tnCxSVVvJDJIvChQW/JOEpNH1TGbscnABot0x460bZ8eMQJJQafbCHXJL7bxdnbMYK8b2XxwRW0Jzlba3bjtv0wzDEBZqfpzBZNfFBCfBLZob//ufvjvU026f4HEwR4fHI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785422715; c=relaxed/simple; bh=FfadgGZINfxKONeZfaoTJnTKPjauu19O695BQdZEH10=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZDEsz0y7e4+Cm8c22GFliIrC+y6/eK6ClDiuG3ckUa0BrHAb/sdFAudzTEnk0+LxBrVdIoXCAjE1T21jmADKTwcTQGioEv7fsXHhxDd5YEzaDYAIQCzwYWWqbLe0QeTwsfT0YrF5RJANX+kjCMk6p42cA1JtaZ7KmSVYvnEcwlM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=TvoUDJdC; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="TvoUDJdC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1DD6D1F00A3A; Thu, 30 Jul 2026 14:45:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1785422713; bh=ef3faEWXdXBsFiIw3EldjPxJuKl/ABGmXcLhsAjGG24=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=TvoUDJdChWjQTzAlz/nbHnRZ9/ZffwNqJKGjxbH4L4VVHdJUV4b74RzvGieY/Pf8N dqYB2f3kF2wAoxDLZa40BlugKEpoWsh501hwjY6v0bmKR5kvRSHu3aPo0fu1S69uvb FWuBuqtV/I1SkrTfv06UVDEPXxw/NUyja49sjWtc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Guangshuo Li , Hans Verkuil Subject: [PATCH 7.1 532/744] media: vidtv: fix reference leak on failed device registration Date: Thu, 30 Jul 2026 16:13:25 +0200 Message-ID: <20260730141455.579286099@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260730141444.267951807@linuxfoundation.org> References: <20260730141444.267951807@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Guangshuo Li commit 9aa21e1549db8882ff77b691e7714153df21dff0 upstream. When platform_device_register() fails in vidtv_bridge_init(), the embedded struct device in vidtv_bridge_dev has already been initialized by device_initialize(), but the failure path returns the error without dropping the device reference for the current platform device: vidtv_bridge_init() -> platform_device_register(&vidtv_bridge_dev) -> device_initialize(&vidtv_bridge_dev.dev) -> setup_pdev_dma_masks(&vidtv_bridge_dev) -> platform_device_add(&vidtv_bridge_dev) This leads to a reference leak when platform_device_register() fails. Fix this by calling platform_device_put() before returning the error. The issue was identified by a static analysis tool I developed and confirmed by manual review. Fixes: f90cf6079bf67 ("media: vidtv: add a bridge driver") Cc: stable@vger.kernel.org Signed-off-by: Guangshuo Li Signed-off-by: Hans Verkuil Signed-off-by: Greg Kroah-Hartman --- drivers/media/test-drivers/vidtv/vidtv_bridge.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/media/test-drivers/vidtv/vidtv_bridge.c +++ b/drivers/media/test-drivers/vidtv/vidtv_bridge.c @@ -594,8 +594,10 @@ static int __init vidtv_bridge_init(void int ret; ret = platform_device_register(&vidtv_bridge_dev); - if (ret) + if (ret) { + platform_device_put(&vidtv_bridge_dev); return ret; + } ret = platform_driver_register(&vidtv_bridge_driver); if (ret)