From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E4971FE44A; Thu, 30 Jul 2026 14:50:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785423018; cv=none; b=clLSsSvzxoQy7vBhj8sjvPwER0YM8knw+nAj3xDi0/gAYtb3+umE3VKimZFiZivcgEBp2h3IyGSO/HL5tVGLDmnHMxaO1Nm4rTfVc9mJaU6a+uGq+Kn9wbHsi4XsI2rV2LgVyI3IIhSco5OqYbeQcKzMMjNSOt8qccd7FNlpjFY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785423018; c=relaxed/simple; bh=m/3N+bdfPLPCav5KTrBmWV/By4Uke9bmSjvb/fjqOsQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=i6dJ505Ts1oiiT78xgG+oMG1Uj6AMfSegIRojaAeQsSLuj4sTw9+opSFxzqgwFTf4l5d+8oWM2b6zOoq4pXl/fZlgiIUlS8roQftn542TPoo2IiXx+eSqpYTnRUhe7S3QUPnvPq/Wx+oHrk+JwzWJCTlk4Y8zlxkw3f6v1J6J4c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=cSW9uOGf; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="cSW9uOGf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 040971F000E9; Thu, 30 Jul 2026 14:50:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1785423017; bh=OdBZCnnCLzVPcIoDXbHfnkLU3YUU7HxjZLCAC+5BhJ0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=cSW9uOGflakU6HDKH11bakrCtmMjos/ouzSEKGmLHsnyq9mgb4E038IdJen2LHHKE XyD2xyAEaTfT8Hp1+j8zy2n0sZBaGgBPOiRr3XjGodwCWes83UKcD4R1ltLWWLIGzO th9R0d5fHx48ribPMEbr4wdwpROgi+KUCuG/iCLw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yuan Tan , Zhengchuan Liang , Xin Liu , Douya Le , Ren Wei , Ilya Dryomov Subject: [PATCH 7.1 636/744] libceph: reject zero bucket types in crush_decode Date: Thu, 30 Jul 2026 16:15:09 +0200 Message-ID: <20260730141457.791640525@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260730141444.267951807@linuxfoundation.org> References: <20260730141444.267951807@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Douya Le commit 05f90284223381005d6bcddab3fda4a97f9c3401 upstream. CRUSH bucket type 0 is reserved for devices. The mapper relies on that invariant and uses type 0 to identify leaf devices. If crush_decode() accepts a bucket with type 0, a malformed CRUSH map can make the mapper treat a negative bucket ID as a device and pass it to is_out(), which then indexes the OSD weight array with a negative value. Reject zero bucket types while decoding the CRUSH map so the invalid state never reaches the mapper. Cc: stable@vger.kernel.org Fixes: f24e9980eb86 ("ceph: OSD client") Reported-by: Yuan Tan Reported-by: Zhengchuan Liang Reported-by: Xin Liu Assisted-by: Codex:GPT-5.4 Signed-off-by: Douya Le Signed-off-by: Ren Wei Reviewed-by: Ilya Dryomov Signed-off-by: Ilya Dryomov Signed-off-by: Greg Kroah-Hartman --- net/ceph/osdmap.c | 2 ++ 1 file changed, 2 insertions(+) --- a/net/ceph/osdmap.c +++ b/net/ceph/osdmap.c @@ -518,6 +518,8 @@ static struct crush_map *crush_decode(vo ceph_decode_need(p, end, 4*sizeof(u32), bad); b->id = ceph_decode_32(p); b->type = ceph_decode_16(p); + if (b->type == 0) + goto bad; b->alg = ceph_decode_8(p); if (b->alg != alg) { b->alg = 0;