From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07AB5331A61; Fri, 7 Aug 2026 14:58:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786114703; cv=none; b=UjYgnDCS6UpukkZLJVhOJMKnjM+SSvAXSRbkbHFdT/pKYm8lnoxqbjB+8f9dAvIEVpnfRxyYhMIaaYqHKwBxbVD73kr22oeJCVYPaZG2L4cpmJ7bQZpOXqmaRau0xROxNtMFzacjuShK1T5kz3uZiNTZy4oIXtoM2oLti08enXw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786114703; c=relaxed/simple; bh=ZkYbXSQ0/qQU4m5ntiDJm3hb7Ph2JRetubM8JjIfakI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IQ5bd7f5sWrU1T6bITcMKLGab1DL34jgPhE9Oy0hGBgoz9sgAEXZ8C5xc0Bko9Ffs7ugrFFERLhyd2T635E1/NhXr5EWBfim4tqEJWrFhmYvPPcEwLyt24lCUTkwD3oZ5NBibqIo02TRbLX5JIkC0V2Q0NZ6nDxzwMcoLuGNbQQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=bMbFwEfI; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="bMbFwEfI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B82E1F00A3A; Fri, 7 Aug 2026 14:58:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1786114701; bh=uYG9kRC2GrHUbOxCTG0muTnVGqo5gYwS7574VCkQL48=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=bMbFwEfI5KobNlJgdkz5CDmUpD+qMH+7TtbBO8/FREdzIZUJo7O3si/vmwFtLsmAf p/GgN79A1g/9BuXg9HdqIbehdGo5jEXIggRy8pKnoh07IKE8WF9m3ha9KqHY461fcf YiF0zh6w0UuLXieio54ikeVLJGqDDO2wa6VEZNHI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Abdun Nihaal , Wolfram Sang , Bartosz Golaszewski , Sasha Levin Subject: [PATCH 6.18 019/396] gpio: sloppy-logic-analyzer: Fix memory leak in gpio_la_poll_probe() Date: Fri, 7 Aug 2026 16:32:59 +0200 Message-ID: <20260807143424.690071545@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260807143424.272339768@linuxfoundation.org> References: <20260807143424.272339768@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Abdun Nihaal [ Upstream commit 7a7baebd9f23ba4f24796775472b2fd00dcd95d9 ] The memory allocated for priv->blob.data is not freed in the error paths that follow the fops_buf_size_set() call in gpio_la_poll_probe(), as well as in the remove function. Fix that by using device managed action to free the memory on remove. Fixes: 7828b7bbbf20 ("gpio: add sloppy logic analyzer using polling") Signed-off-by: Abdun Nihaal Reviewed-by: Wolfram Sang Link: https://patch.msgid.link/20260715075311.527753-1-nihaal@cse.iitm.ac.in Signed-off-by: Bartosz Golaszewski Signed-off-by: Sasha Levin --- drivers/gpio/gpio-sloppy-logic-analyzer.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpio/gpio-sloppy-logic-analyzer.c b/drivers/gpio/gpio-sloppy-logic-analyzer.c index 969dddd3d6faf..0f4a6228a7488 100644 --- a/drivers/gpio/gpio-sloppy-logic-analyzer.c +++ b/drivers/gpio/gpio-sloppy-logic-analyzer.c @@ -161,6 +161,13 @@ static int fops_buf_size_get(void *data, u64 *val) return 0; } +static void fops_buf_release(void *data) +{ + struct gpio_la_poll_priv *priv = data; + + vfree(priv->blob.data); +} + static int fops_buf_size_set(void *data, u64 val) { struct gpio_la_poll_priv *priv = data; @@ -239,6 +246,9 @@ static int gpio_la_poll_probe(struct platform_device *pdev) return ret; fops_buf_size_set(priv, GPIO_LA_DEFAULT_BUF_SIZE); + ret = devm_add_action_or_reset(dev, fops_buf_release, priv); + if (ret) + return ret; priv->descs = devm_gpiod_get_array(dev, "probe", GPIOD_IN); if (IS_ERR(priv->descs)) -- 2.53.0