From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 020DA43F089; Mon, 17 Aug 2026 14:54:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786978488; cv=none; b=IApCVETxLHc93otgqTPWif4Rz4fIYxF2B0OG8M+ePLLGMxgHfegMFZZN2hJEpTZX/5/KgTzUa1nUoNDst2Zmgbmd0iWk279eyDIyV0T7QVh44snouset7+V4uaBnLUPe24FoBze3aRXEkoAVogJja8f61AiVcuQGFmxLbc+w8Mo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786978488; c=relaxed/simple; bh=vI8cJcOEE/mo69g+VEbDVSFb1EepbUtUkLw5dlcqrqQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=G7Lj3xxfu8JNMAHAvja+JA3KpeXIK7EL8nOpWtkUjD/CGU2sbIZUDoDviCLpOkLYr2MgqIImceXGPuZd4g9x684jIfa5yYuxloTy22Lq6SZ2t8QhXFU0gIkyYNHMsb8ui5BUTIStcykN/cyKjb07er9Ts583s1ZpRZb1hhgUY3o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ZD3aCDea; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ZD3aCDea" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9AC7F1F00A3A; Mon, 17 Aug 2026 14:54:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1786978482; bh=43oXkU8eBxWNZoECTomJgA39ttwUgfYS8WbuZnx7z1I=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ZD3aCDeahSZXEb9Dqv1043ElkBZf9Y7CWLy7sKWKOyh/p45traF1qbJOaWXSzE2MU 86IJhl9TfMiOTUQsCE84QyYgucFiSV338Zg6Ujg2H2XnGi5ajvb8Ne+yrCYwAN4bAF N8f67b04nM6pqe8Uj1jeMtwgRUjRTH7gDOrFWVLU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Hongyan Xu , Niklas Cassel , Damien Le Moal , Sasha Levin Subject: [PATCH 6.6 053/156] ata: pata_sl82c105: fix bridge revision use-after-free Date: Mon, 17 Aug 2026 15:33:07 +0200 Message-ID: <20260817132536.663200580@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817132534.666299318@linuxfoundation.org> References: <20260817132534.666299318@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.6-stable review patch. If anyone has any objections, please let me know. ------------------ From: Hongyan Xu [ Upstream commit 7700a31039cdc6715cb6cce7e7a664ee4e945f67 ] pci_get_slot() returns a referenced PCI device. Commit 44c10138fd4b ("PCI: Change all drivers to use pci_device->revision") replaced a configuration-space read with direct access to the cached revision field, but left that access after pci_dev_put(). The bridge may therefore be freed before its revision is read. Read the revision before dropping the reference. Fixes: 44c10138fd4b ("PCI: Change all drivers to use pci_device->revision") Signed-off-by: Hongyan Xu Reviewed-by: Niklas Cassel Signed-off-by: Damien Le Moal Signed-off-by: Sasha Levin --- drivers/ata/pata_sl82c105.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/ata/pata_sl82c105.c b/drivers/ata/pata_sl82c105.c index 93882e976ede4..2a5ce46af5a0a 100644 --- a/drivers/ata/pata_sl82c105.c +++ b/drivers/ata/pata_sl82c105.c @@ -264,6 +264,7 @@ static struct ata_port_operations sl82c105_port_ops = { static int sl82c105_bridge_revision(struct pci_dev *pdev) { struct pci_dev *bridge; + u8 revision; /* * The bridge should be part of the same device, but function 0. @@ -285,8 +286,9 @@ static int sl82c105_bridge_revision(struct pci_dev *pdev) /* * We need to find function 0's revision, not function 1 */ + revision = bridge->revision; pci_dev_put(bridge); - return bridge->revision; + return revision; } static void sl82c105_fixup(struct pci_dev *pdev) -- 2.53.0