From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE9B03E025C; Mon, 17 Aug 2026 14:45:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786977949; cv=none; b=OjlHE9n9F0OQauJYU5/L7N56rdARd4zTOQzpRU1Zfr+uUTmoRVrom3j/baugXijvhDKCo6cqnvW/MomZqo9CnLWc4HeoZnS0Pp8jKosbFsR/xwpUoGpq1w7hID6YitKVYckdcqi4wpVd9d/BymxnCVmN1L/gZZ6BEqEhSibi4i0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786977949; c=relaxed/simple; bh=hN5duzhZSZw/7/0cJlXZkI75g/aqjsNikdM0BSycykU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=E4ki1uM33JmMz8OojAlnWjb0RVcqtUgrQ8MQ5jOcdRocYpdpeQFwjNeIcRtn6dQ10F1yiOrbmdi6U9MSnvHoq8qC3z0cew8kSf73QSrlQk8ELbKx3gbY5r+FN6bsHOmuJDBmpDaa8HyIBu2TjW+O9yJDIEr779iqfA0XuLicbug= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=pPbdTCg7; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="pPbdTCg7" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CDF6A1F00A3A; Mon, 17 Aug 2026 14:45:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1786977948; bh=ZappNQ+q4Sa1t838GD0LnmToGLPyZxK7HBadBDV2loo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=pPbdTCg7YZE++NegjhMqsxMcbQfL2W30G1+UhCJVqjWVvCo2RUexA7+Qwqot2hwuD ixEiDPMi04icTN6HsstxCfIu6PaiTdkJdEdodPgSox+OipbHGsypJBTHQXpVV4SRti VmMq5tMq6732Pw+HYUtd6u26rjYWckOUZt4BikAY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Pavan Chebbi , Keegan Freyhof , Michael Chan , Jakub Kicinski , Sasha Levin Subject: [PATCH 6.12 050/181] bnxt_en: Fix PTP PPS setting bug Date: Mon, 17 Aug 2026 15:32:24 +0200 Message-ID: <20260817132537.370724646@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817132535.394764707@linuxfoundation.org> References: <20260817132535.394764707@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Keegan Freyhof [ Upstream commit 80eaf88efec33ac77ed7726d066c4f2f932cc329 ] The existing driver logic is always turning on PTP_CLK_REQ_PPS regardless of the "on" parameter passed to bnxt_ptp_enable(). During shutdown, PTP_CLK_REQ_PPS may be turned off and this bug will do the opposite and may trigger a PCIe PTM request TLP. On some systems this can trigger a PCIe AER. Fix it by properly configuring PTP_CLK_REQ_PPS based on the "on" parameter. Fixes: 9e518f25802c ("bnxt_en: 1PPS functions to configure TSIO pins") Reviewed-by: Pavan Chebbi Signed-off-by: Keegan Freyhof Signed-off-by: Michael Chan Link: https://patch.msgid.link/20260731190937.807270-6-michael.chan@broadcom.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c index 6dfa0ab74c332..02276b9ac5c62 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c @@ -494,12 +494,15 @@ static int bnxt_ptp_enable(struct ptp_clock_info *ptp_info, return rc; case PTP_CLK_REQ_PPS: /* Configure PHC PPS IN */ - rc = bnxt_ptp_cfg_pin(bp, 0, BNXT_PPS_PIN_PPS_IN); + pin_id = 0; + if (!on) + break; + rc = bnxt_ptp_cfg_pin(bp, pin_id, BNXT_PPS_PIN_PPS_IN); if (rc) return rc; rc = bnxt_ptp_cfg_event(bp, BNXT_PPS_EVENT_INTERNAL); if (!rc) - ptp->pps_info.pins[0].event = BNXT_PPS_EVENT_INTERNAL; + ptp->pps_info.pins[pin_id].event = BNXT_PPS_EVENT_INTERNAL; return rc; default: netdev_err(ptp->bp->dev, "Unrecognized PIN function\n"); -- 2.53.0