From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A47723D8132; Mon, 17 Aug 2026 14:03:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786975390; cv=none; b=M5twqpIUg9c6A2KaBjl28qD7N/T0k6CFI9f6XvMhUhIarjCH0VwxskfFP29g06pcL4TKM7/QqS/3tBpNh9lLrLsa4EpzrY8jkiu5zrLyxLF0EjUMkMx4yc1zgNZbQtzAIpgeR4OyND7GL4baytcDJyINlIGj+Wq+yCC4PoX4Y3Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786975390; c=relaxed/simple; bh=+d5wpq9Ec18ftAtJdJP+Goee8KMizYA5tzTuKsaZEDE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Xxj/IoznJYFSRTScjRCvZp5j4zz96XICz27HVMh335n4xjxPn+Jq8tz5WK7iDa4g3rJaWc2OIeA4C03ENcdob9nfW4wbnekSCLYO9JL6Itp9jQM86smkBIYCFZNo28/2vW67pctAqnNIjQwmu7cQT2dGx1/rECcdSPDmh0/8NfQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=hh4giAQ+; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="hh4giAQ+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 088C41F00A3D; Mon, 17 Aug 2026 14:03:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1786975389; bh=c8lFBjNES9CqBY37OCWIBBkDeeigrZ6ytiJK3y2BWb0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=hh4giAQ+7d3LAZ+SvlMFXjC/kdDqcrjuo6JwtOouq/7CwdIHMOYOJs/pjI7w9PMq9 HNvleHQrfXjKc1hFltfJVk++/1VwR4KPCidgDyBSKNtX7DuAehDNhF5FUsA915w06r IKQqFhLgWOOyPZ4nZtfeCB9icQ0cLCd/PP0FXDlQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Pengpeng Hou , Miquel Raynal , Sasha Levin Subject: [PATCH 5.10 012/389] mtd: mtdswap: remove debugfs stats file on teardown Date: Mon, 17 Aug 2026 15:27:31 +0200 Message-ID: <20260817132539.325429123@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817132538.796021292@linuxfoundation.org> References: <20260817132538.796021292@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Pengpeng Hou [ Upstream commit 66fb31358108d10245b9e4ef0eef3e7d9747055e ] mtdswap_add_debugfs() creates an mtdswap_stats debugfs file under the per-MTD debugfs directory, but mtdswap_remove_dev() never removes it before freeing the mtdswap_dev. Store the returned dentry and remove it during device teardown before the driver-private state is freed. Fixes: a32159024620 ("mtd: Add mtdswap block driver") Signed-off-by: Pengpeng Hou Signed-off-by: Miquel Raynal Signed-off-by: Sasha Levin --- drivers/mtd/mtdswap.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/mtdswap.c b/drivers/mtd/mtdswap.c index 58eefa43af1414..bd4ac120996243 100644 --- a/drivers/mtd/mtdswap.c +++ b/drivers/mtd/mtdswap.c @@ -125,6 +125,7 @@ struct mtdswap_dev { char *page_buf; char *oob_buf; + struct dentry *debugfs_stats; }; struct mtdswap_oobdata { @@ -1264,7 +1265,8 @@ static int mtdswap_add_debugfs(struct mtdswap_dev *d) if (IS_ERR_OR_NULL(root)) return -1; - debugfs_create_file("mtdswap_stats", S_IRUSR, root, d, &mtdswap_fops); + d->debugfs_stats = debugfs_create_file("mtdswap_stats", 0400, root, + d, &mtdswap_fops); return 0; } @@ -1465,6 +1467,7 @@ static void mtdswap_remove_dev(struct mtd_blktrans_dev *dev) { struct mtdswap_dev *d = MTDSWAP_MBD_TO_MTDSWAP(dev); + debugfs_remove(d->debugfs_stats); del_mtd_blktrans_dev(dev); mtdswap_cleanup(d); kfree(d); -- 2.53.0