From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E896441037; Mon, 17 Aug 2026 14:12:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786975949; cv=none; b=kFBudcH8NR8rG/3JCLAbgc6guu+Vd8dxBda+HX/nHV+4D2+FKnDOF9KXS/oeW5m57xXVgh6odf5So8RjNU415zpYzdKYd5EmXGAOVUQH78XbxwlNntfc7psbnaRAipWHdVk9tkDo5YqxUPenG51xkSoCRxV0891gHq5RQVnaXFo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786975949; c=relaxed/simple; bh=esinDqGPUzArO6Zwpy/a12UOmlkNorRSSjk6I9WmWzc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UTzQw/b0IMnwCjwneREScKldEwCsYQUw5qDUZNHKqdKVSxajCq3oIeLJK02wCm0iqtjxPMMbiDuK7pcVTIyz1sVG10guqFKvnth9J8tUBfAFuzHtY4rpSDYak2f9NhUXQzH2b+GgRH+z+4g3JYZWzS50M/kysW9lWWghEpjefbU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=YfdQWS81; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="YfdQWS81" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 959801F000E9; Mon, 17 Aug 2026 14:12:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1786975948; bh=ltK76Oor8U4vbaa7UIWfcgAyT/MeKkLbnACbydIPuJk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=YfdQWS81/y5bt4vOOi1WhzRf58UrIAOacFRGf0A1ARjbNrJASbndzaT/3oEDtjqvZ Ephu/bxvdpgzLTueJqWgMxCXGPe+tuqjcu6p3el5rpYmB1NQYtDoYb8mebmTono79O vvy8+rbbtA2N8gnjFAlXCjvnU/46kJmYWRsody2I= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Uday Khare , Mark Brown , Sasha Levin Subject: [PATCH 5.10 205/389] ASoC: max98090: fix missing IS_ERR() before PTR_ERR() on mclk lookup Date: Mon, 17 Aug 2026 15:30:44 +0200 Message-ID: <20260817132547.224081675@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817132538.796021292@linuxfoundation.org> References: <20260817132538.796021292@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Uday Khare [ Upstream commit a792ce0fad61a70793ec565743f11d6ca534de59 ] In max98090_probe(), the -EPROBE_DEFER check after devm_clk_get() is broken due to a missing IS_ERR() guard. The code intends to return -EPROBE_DEFER only when the clock lookup fails with that specific error. However, without IS_ERR() the check: if (PTR_ERR(max98090->mclk) == -EPROBE_DEFER) is called unconditionally, including when devm_clk_get() succeeds and returns a valid pointer. Calling PTR_ERR() on a valid pointer reinterprets its address as a signed long; the result is arbitrary and is almost never equal to -EPROBE_DEFER, so the check silently does nothing in the success case. When devm_clk_get() fails with any error other than -EPROBE_DEFER the check is also skipped, leaving max98090->mclk holding an error pointer with no indication to the caller. This means a deferred probe will never actually be triggered for this device, and any non-EPROBE_DEFER clock error is silently swallowed with the error pointer left in the mclk field. Fix this by adding the missing IS_ERR() guard around the PTR_ERR() call, matching the pattern already used in the sibling max98088 and wm8960 drivers. Fixes: b10ab7b838bd ("ASoC: max98090: Add master clock handling") Signed-off-by: Uday Khare Link: https://patch.msgid.link/20260720104254.14948-1-udaykhare77@gmail.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/max98090.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs/max98090.c index c7df685be4ea5..531cd172cb5cb 100644 --- a/sound/soc/codecs/max98090.c +++ b/sound/soc/codecs/max98090.c @@ -2393,8 +2393,9 @@ static int max98090_probe(struct snd_soc_component *component) dev_dbg(component->dev, "max98090_probe\n"); max98090->mclk = devm_clk_get(component->dev, "mclk"); - if (PTR_ERR(max98090->mclk) == -EPROBE_DEFER) - return -EPROBE_DEFER; + if (IS_ERR(max98090->mclk)) + if (PTR_ERR(max98090->mclk) == -EPROBE_DEFER) + return -EPROBE_DEFER; max98090->component = component; -- 2.53.0