From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B409D2773C3; Mon, 17 Aug 2026 15:49:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786981780; cv=none; b=N3cmN22KQGNo1hUaTD81p0r3WSki3tx5nza4ZjMcjQ3o3bum/G/iGmu3wFEl8ZNU5ASZ/VvZJ2W8wcMf8wc8y2Gk5c/jiXo7DW6XAl9IKMbYbKI0SsPQPYGkTteYlhybwlKWt40u38q9noVRz33nb6R0I1asnTXCXPK3oWTbp4s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786981780; c=relaxed/simple; bh=KNqtq7cZH+z+YbRIDHrssZ7GumMCLkuaX3RHUb0Lcew=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AObrczf4d5CeKYkQgqvM2PLTECjKqWP+IJl6fud/vjOHj8wMZ8oVSwpBdA5pbBkKi8gh0aRl7jijg43u9QKE8w3BtfhHV2Hz5pACuQe2fv1YPawneqQ6Dqpqdadg7LbOgbWnm3T3J21X53fAPzNwtvqxrQwI/u/rjOpxr+kEyhA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=10hH2T+J; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="10hH2T+J" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8E3DF1F000E9; Mon, 17 Aug 2026 15:49:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1786981778; bh=eiiXkoxCzkICIBoaYv0pHz0oOrj5p1ZL+U6ZxrizS30=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=10hH2T+JD23i0m61UBGkZQ27/KHwjh6USzpIhpa4KGDZiofwlz2AXr8kCxs71C5nz Hvl/91eCNuHVPVgiebPzqsPZ+lgSmYP97Y+6p1R/sWoAO0yxlO+hwlw4uKnXxS0/Hz AjlsUqBXC54bk7Q1kpx/7iPXWhGB5xitEffT6nPQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable@vger.kernel.org, Tze Yee Ng , Dinh Nguyen , Sasha Levin Subject: [PATCH 5.10 307/389] firmware: stratix10-svc: fix memory leaks and list corruption bugs Date: Mon, 17 Aug 2026 15:32:26 +0200 Message-ID: <20260817132550.998667043@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817132538.796021292@linuxfoundation.org> References: <20260817132538.796021292@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Tze Yee Ng [ Upstream commit 9119ceb76e987c2ec2b549ea100e3268ce3a1c7c ] Fix a memory leak when gen_pool_alloc() fails by freeing pmem on the error path. Switch pmem allocation from devm_kzalloc() to kzalloc() with explicit kfree() in the free path to match its list-managed lifetime. Remove the erroneous list_del(&svc_data_mem) which corrupted the list head on failed lookups. Fixes: 7ca5ce896524 ("firmware: add Intel Stratix10 service layer driver") Cc: stable@vger.kernel.org#5.0+ Signed-off-by: Tze Yee Ng Signed-off-by: Dinh Nguyen (cherry picked from commit 9119ceb76e987c2ec2b549ea100e3268ce3a1c7c) Signed-off-by: Sasha Levin --- drivers/firmware/stratix10-svc.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/stratix10-svc.c b/drivers/firmware/stratix10-svc.c index 6b6a819fcddfa..ae6d942ab2d75 100644 --- a/drivers/firmware/stratix10-svc.c +++ b/drivers/firmware/stratix10-svc.c @@ -911,13 +911,15 @@ void *stratix10_svc_allocate_memory(struct stratix10_svc_chan *chan, struct gen_pool *genpool = chan->ctrl->genpool; size_t s = roundup(size, 1 << genpool->min_alloc_order); - pmem = devm_kzalloc(chan->ctrl->dev, sizeof(*pmem), GFP_KERNEL); + pmem = kzalloc(sizeof(*pmem), GFP_KERNEL); if (!pmem) return ERR_PTR(-ENOMEM); va = gen_pool_alloc(genpool, s); - if (!va) + if (!va) { + kfree(pmem); return ERR_PTR(-ENOMEM); + } memset((void *)va, 0, s); pa = gen_pool_virt_to_phys(genpool, va); @@ -950,10 +952,9 @@ void stratix10_svc_free_memory(struct stratix10_svc_chan *chan, void *kaddr) (unsigned long)kaddr, pmem->size); pmem->vaddr = NULL; list_del(&pmem->node); + kfree(pmem); return; } - - list_del(&svc_data_mem); } EXPORT_SYMBOL_GPL(stratix10_svc_free_memory); -- 2.53.0