From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A963D3EC699; Mon, 17 Aug 2026 14:40:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786977606; cv=none; b=dNlKgEK1XoZfTh8YjbGv57BhkOEG4z6OzVAL02z3XzF9IQW+D1IfI+ESv3yv8jLOqj4/QwHfxLn6WgOLW9vnF1VMUN4xTFgCTHrY+sj4cAFFhFQB9GPJciMU+AEP3zwVosUTC9hRSzPW689wnOOynh/DtGDad9c3Y+kmDxUwYOQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786977606; c=relaxed/simple; bh=Icqo79E2nO5MdA2eti+F1hApvR1Ib0yp8FosJI0CYWc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ekaRmknSZuG+A2tS4VaIozYTiw4yDmoD5cXHyTHdIwAi3Gy/eRf4k705yYbLHEiC62RTV0UI9d1ZPZCIij7HTfRF6lUqzdMWKtyCXmkoWkeufBXhPLje3e7xyOyoxKDUCwLc97IgpndHJGWUiMqCSfrnV3QS1G89KKZK1yAlu8g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=lQj6NSlw; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="lQj6NSlw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 042DD1F000E9; Mon, 17 Aug 2026 14:40:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1786977605; bh=yZL6YAOQAjnGhxEJK5kgF2aqGRek8IeOnxPqxY+kzdI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=lQj6NSlwBgtpA+74mREMkb9/1xCIR6+g0X/y26Lm8MUrCZ+f2uGFsMrw8Iwv5TXuN H7lkDHBQrYXTRW+ZAv0UZgznLrQnQ7/C76FFM3TTCEzcHDuXqnlv0rJLPH2GBC7vUx Vpe2DgJewes70Id4hrNMBzu2ixJHUi+FQTvlDGuQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Pavan Chebbi , Keegan Freyhof , Michael Chan , Jakub Kicinski , Sasha Levin Subject: [PATCH 5.15 386/456] bnxt_en: Fix PTP PPS setting bug Date: Mon, 17 Aug 2026 15:32:56 +0200 Message-ID: <20260817132554.544558729@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260817132539.792407575@linuxfoundation.org> References: <20260817132539.792407575@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Keegan Freyhof [ Upstream commit 80eaf88efec33ac77ed7726d066c4f2f932cc329 ] The existing driver logic is always turning on PTP_CLK_REQ_PPS regardless of the "on" parameter passed to bnxt_ptp_enable(). During shutdown, PTP_CLK_REQ_PPS may be turned off and this bug will do the opposite and may trigger a PCIe PTM request TLP. On some systems this can trigger a PCIe AER. Fix it by properly configuring PTP_CLK_REQ_PPS based on the "on" parameter. Fixes: 9e518f25802c ("bnxt_en: 1PPS functions to configure TSIO pins") Reviewed-by: Pavan Chebbi Signed-off-by: Keegan Freyhof Signed-off-by: Michael Chan Link: https://patch.msgid.link/20260731190937.807270-6-michael.chan@broadcom.com Signed-off-by: Jakub Kicinski Signed-off-by: Sasha Levin --- drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c index 328ae267eba5c..e337e78c00365 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c @@ -375,12 +375,15 @@ static int bnxt_ptp_enable(struct ptp_clock_info *ptp_info, return rc; case PTP_CLK_REQ_PPS: /* Configure PHC PPS IN */ - rc = bnxt_ptp_cfg_pin(bp, 0, BNXT_PPS_PIN_PPS_IN); + pin_id = 0; + if (!on) + break; + rc = bnxt_ptp_cfg_pin(bp, pin_id, BNXT_PPS_PIN_PPS_IN); if (rc) return rc; rc = bnxt_ptp_cfg_event(bp, BNXT_PPS_EVENT_INTERNAL); if (!rc) - ptp->pps_info.pins[0].event = BNXT_PPS_EVENT_INTERNAL; + ptp->pps_info.pins[pin_id].event = BNXT_PPS_EVENT_INTERNAL; return rc; default: netdev_err(ptp->bp->dev, "Unrecognized PIN function\n"); -- 2.53.0