From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0A0447AF6D; Thu, 20 Aug 2026 16:44:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787244283; cv=none; b=oUEKnYLeoKuM16Hd/t/jMVd5kpCTeTw4r/50GKCyIHxphyxHpAdg2L4Gc6TwXJupBGmiwhB1PL9yW9PjleimKgcfix8/Q3SDdiF7DJMBz6YpSKNqBo5mG0n4GJi8KYxWKP8K5AVFY+TRl5k2tIg0194hWYNR8wOE8jNyFTWy/KU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787244283; c=relaxed/simple; bh=6wDLayFmq1jfXeAdhUor1YwO5z9HhBHXIMN266cjxSw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IMJWmhTaqgv38DibAJcbYGYpQS6F1hqfP5p280KWpTHoIR/VSsFYhZjjHFoxNGcpPg3vRh54Bxuzs6+LWICY9k8Xqb68PGNCtvWfEw8GZAkQyX9ShVo8l/pzuUI//HaNB4aw6XVqHhE48KLo8WMZhBTD4H/NAF0smzDEJ7DrSQQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=nxDXWWkL; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="nxDXWWkL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1DDE31F000E9; Thu, 20 Aug 2026 16:44:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1787244282; bh=4gVw/7SIWHnpUS1Zop+HRm/Z5oWTAvPgfGwb9XhSGeU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=nxDXWWkLdpLh/RZH7gbI1qYlc1jSmIMkRs1KWQiz8CuYpWC42aDRYi1XgU68AHRlI zCYim4qq1DbF0bghgEfBEvve94A65bdBpfFUWNmlz2S1EtdExfDhd1pgOBiIdyKDMK WAhgfHmufr8Hd5Xw2mrh5vzAZraQ6SQMau7LHsZ4= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Maoyi Xie , Johannes Berg , Sasha Levin Subject: [PATCH 5.10 115/235] wifi: libertas_tf: fix use-after-free in lbtf_free_adapter() Date: Thu, 20 Aug 2026 16:55:51 +0200 Message-ID: <20260820145219.940976794@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260820145216.426568665@linuxfoundation.org> References: <20260820145216.426568665@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Maoyi Xie [ Upstream commit aa6dcd5c8dd9ba1d7d0f60093bcda41c0d6d438d ] lbtf_free_adapter() calls timer_delete(&priv->command_timer), which does not wait for a running command_timer_fn() callback. lbtf_free_adapter() runs on the teardown path right before ieee80211_free_hw() frees priv, both in lbtf_remove_card() and in the probe error path. command_timer is armed by mod_timer() in lbtf_cmd() whenever a firmware command is sent. command_timer_fn() dereferences priv. If a command times out as the device is removed, command_timer_fn() runs concurrently with teardown and dereferences priv after it has been freed. This is the same use-after-free that commit 03cc8f90d053 ("wifi: libertas: fix use-after-free in lbs_free_adapter()") fixed in the sibling libertas driver. The libertas_tf variant has the identical pattern and was left unchanged. Use timer_delete_sync() so any in-flight callback completes before priv is freed. Fixes: 06b16ae53192 ("libertas_tf: main.c, data paths and mac80211 handlers") Cc: stable@vger.kernel.org Signed-off-by: Maoyi Xie Link: https://patch.msgid.link/178211481807.2212567.8773346114561900100@maoyixie.com Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/marvell/libertas_tf/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/wireless/marvell/libertas_tf/main.c +++ b/drivers/net/wireless/marvell/libertas_tf/main.c @@ -174,7 +174,7 @@ static void lbtf_free_adapter(struct lbt { lbtf_deb_enter(LBTF_DEB_MAIN); lbtf_free_cmd_buffer(priv); - del_timer(&priv->command_timer); + timer_delete_sync(&priv->command_timer); lbtf_deb_leave(LBTF_DEB_MAIN); }