From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CF8614A619; Tue, 25 Aug 2026 14:01:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787666480; cv=none; b=QPWH7CiMIzR1V1BbckAnnMI8XaBRy0mH9a2csmwVOg0iOz0hGmmSfGQiqf1xj7RPtvDNWsvgahN0c6oJMVyU79ele7Oemo0yggvMTAMHfb4+4c0CQyH3lEBzB3v4sQHzhn9WQ+FyNCA8ei0Xe3O1PBV3+XyoUNfUBi6s3r13C+I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787666480; c=relaxed/simple; bh=+9frnykz1bjZ8VPMNM/iObnv/ErlKljJJ4yPj9QTXc0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DMmdJSQiNL2OEnuSu9JSeWpGo+H1t5HjRaZjkl0bJOcGQ8KPkfLQoPshz2U58T/A84GRAwJtnr6QlNoitW0wYpg3rOMKoinM/u7IaIvN1hPiRCQfl9bHJDxABPjTzu/BDDYZyjPccrqUIh3DGtBX7IGwBL2SLOqF/fonVnG9hY8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=JyMsGGws; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="JyMsGGws" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CFF751F000E9; Tue, 25 Aug 2026 14:01:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1787666479; bh=JImrjkxFiOHBUPQs5xN/MjiRRRfVbjVDynRtLaqkcG8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=JyMsGGws933hXcgXQxsTERhEi0i5pvG4lkpNbnkFfng7Uh0G7dXXaWzUqMm9pOwzX MNCtcQmB0ETsQ+41floRIZYQ5xJhmXkd/TiYbLeoV6iVOjJhsh16VGFO/DfCfCSw1K 73RCzDIMq6fCZBBT/79Ebt3sb9LdW4Eiz2322xY8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jann Horn , Jiri Kosina Subject: [PATCH 5.10 55/57] HID: core: fix number/pointer type confusion on long items Date: Tue, 25 Aug 2026 15:27:17 +0200 Message-ID: <20260825132543.492238815@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260825132541.342390421@linuxfoundation.org> References: <20260825132541.342390421@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jann Horn commit 28abce951343fcec26e397610868efa4e1395c3f upstream. When fetch_item() is called by hid_scan_report() on an item with HID_ITEM_TAG_LONG, it stores a pointer to the item data in item->data.longdata instead of storing a value directly in item->data.{u8/u16/u32}. When item_udata() or item_sdata() encounters such an item, it incorrectly assumes that the item is in short format, and therefore returns the lower part of a kernel pointer reinterpreted as a number. When a HID device is connected whose descriptor contains a HID_GLOBAL_ITEM_TAG_REPORT_SIZE encoded in long format with size=4, this causes the lower half of a kernel pointer to be printed into dmesg as a number, like this: hid (null): invalid report_size 107953555 To fix it, let item_udata() and item_sdata() verify that the item is in short format. Note that this bug only affects hid_scan_report(), while the main parsing pass hid_parse_collections() will always bail out when encountering a long item. Sidenote: There are currently no users of data.longdata; maybe we should just remove any parsing of long-format descriptors as a follow-up. Fixes: 3dc8fc083dbf ("HID: Use hid_parser for pre-scanning the report descriptors") Cc: stable@vger.kernel.org Signed-off-by: Jann Horn Signed-off-by: Jiri Kosina Signed-off-by: Greg Kroah-Hartman --- drivers/hid/hid-core.c | 6 ++++++ 1 file changed, 6 insertions(+) --- a/drivers/hid/hid-core.c +++ b/drivers/hid/hid-core.c @@ -346,6 +346,9 @@ static int hid_add_field(struct hid_pars static u32 item_udata(struct hid_item *item) { + if (item->format != HID_ITEM_FORMAT_SHORT) + return 0; + switch (item->size) { case 1: return item->data.u8; case 2: return item->data.u16; @@ -356,6 +359,9 @@ static u32 item_udata(struct hid_item *i static s32 item_sdata(struct hid_item *item) { + if (item->format != HID_ITEM_FORMAT_SHORT) + return 0; + switch (item->size) { case 1: return item->data.s8; case 2: return item->data.s16;