From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8918E483BCB; Mon, 31 Aug 2026 14:07:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788185255; cv=none; b=h/0IMYNOYev8SSwPdgmJTgDpATpPc1wVVQDWu/1F2eVqXqeeax6f2Oht0TBlHkWiYrX2JG2+mSX+rbTHuZzJae+PZG9ONt5oojcY3jupTRmXXKva4nEj0JRdYWU3TrSDkyQxttrib3AB+WaNaqJF/mlW1DItUvfJaAUEkxTncsM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788185255; c=relaxed/simple; bh=gPt1lG7Z8DjD1YJYpK0QkiCUEzPDMGr/cQ8hB2lf66M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ov46A6qCvGl7beE39h8XDdn+IblAjGdmoxl5de0raAcVKIuAMeotMGulwlaaalBWWQgygTtFJGOlJyZFUN0msm6IKa3wovq89RnKPIo1QtGvpx5ZPGIZRdrdQMMVviRzf6pM33VVOk7GDmMvyl/3Px4fTu76Y86zXQHUCu4EJYw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=uhlr+ovv; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="uhlr+ovv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2E2C1F000E9; Mon, 31 Aug 2026 14:07:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788185254; bh=zHYZQw7tPGzhvtVJxJl3P3F59dHCmDwGlPoNeIeoaeU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=uhlr+ovvqyGx/rpB5Vp+2/cWsBiD8wOFtX5l+i3VXKgzqatvN4qZzWSFI8VTeLnyk nIdihx3gWinmDUdYn6nmfs6PjeEykv5uLH63ABHjN6kJM0JadQqpUHBh6ZjlQWjlxn 2M3uBW6hbI1Rprt/Krip+r4vT9l50SYXv7LjlBlw= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Gabriel Krisman Bertazi , Vishnu Razdan , Sasha Levin Subject: [PATCH 5.10 05/43] io_uring/io-wq: fix worker accounting when canceling creation callbacks Date: Mon, 31 Aug 2026 15:35:13 +0200 Message-ID: <20260831133358.788219809@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260831133358.571886287@linuxfoundation.org> References: <20260831133358.571886287@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Vishnu Razdan commit 297b5ccea4acacaa47c150f043bce695202afbf1 upstream. create_worker_cb() reserves an io-wq worker slot only after its task-work callback runs. If the callback is canceled before then, io_worker_cancel_cb() still decrements acct->nr_workers. When an existing worker retires with its creation callback pending, that worker has already decremented the same account's worker count. The resulting undercount permits worker creation beyond the account's configured limit. On an AST2600 OpenBMC system, an unchanged sensor daemon reached 4,291 threads with the original kernel. With an equivalent downstream fix, 25 passive samples under its normal workload showed 6-9 threads. Decrement nr_workers only when the canceled callback is not create_worker_cb(). Continuation callbacks still release their reserved slot, and both callback types retain the existing running-count, reference-count, and create-state cleanup. [ Backport: retain the existing worker->wqe->lock protecting worker accounting. ] Fixes: 1d5f5ea7cb7d ("io-wq: remove worker to owner tw dependency") Cc: stable@vger.kernel.org Assisted-by: Codex:gpt-5.6-sol Reviewed-by: Gabriel Krisman Bertazi Link: https://patch.msgid.link/20260811-vrazdan-io-wq-b4-submit-v1-1-719ced16c921@openai.com Signed-off-by: Vishnu Razdan Signed-off-by: Sasha Levin --- io_uring/io-wq.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/io_uring/io-wq.c b/io_uring/io-wq.c index edcb5af514b53..f57743d911b4c 100644 --- a/io_uring/io-wq.c +++ b/io_uring/io-wq.c @@ -195,9 +195,12 @@ static void io_worker_cancel_cb(struct io_worker *worker) struct io_wq *wq = wqe->wq; atomic_dec(&acct->nr_running); - raw_spin_lock(&worker->wqe->lock); - acct->nr_workers--; - raw_spin_unlock(&worker->wqe->lock); + /* create_worker_cb() has not reserved a worker slot yet. */ + if (worker->create_work.func != create_worker_cb) { + raw_spin_lock(&worker->wqe->lock); + acct->nr_workers--; + raw_spin_unlock(&worker->wqe->lock); + } io_worker_ref_put(wq); clear_bit_unlock(0, &worker->create_state); io_worker_release(worker); -- 2.53.0