From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A597D488747; Mon, 31 Aug 2026 14:06:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788185202; cv=none; b=Z2rTRaNbPfRI1SlSgh/Qo7iSiN3nHhUfM1QJpenpr+hrQ1C4D/4LtR733JFI43IhKiwvuF4nrzEaoQz5SvRGq+9GJAaKi1pvLa6JhxpUO5565Jaqag8vobly4MwFoKMRMrXBreVY3AVJRRr26LL0z4L3DN67mLo6TuuxrQ2t+t4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788185202; c=relaxed/simple; bh=ebZAMPh4kfi/SLxtfBrOLCQhwtT/cDQLvRV0aKoCXTU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pKXtT8xYpbKfC8fkQZg0RarYpfU8FkuIYpbz/bOquCAh+g8C175/QbhaDszqd7wthkdLOyousNnk2lzOqDs8b9eNOIWwYS36SXDUcm7jCc2rYGUX4ya9MpZfC5zhSWWdIsxN74fK+ygD4imIBFO5Lx+Z4sXIZ68qOgB1RHhI+AU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=1qpt5mrt; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="1qpt5mrt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C10901F000E9; Mon, 31 Aug 2026 14:06:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788185200; bh=IeLN8I7jdEbK9us4nx7KzXnmHCjzPMOD1SQplmy7AaQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=1qpt5mrt6uMwW54bfzD+QkRdQytorZENI4Koki7NqmuWFopxokRvOvmglLMc29usk tzAnS6SkbE/VW72hECRbWde7QNHb0DhM+6u0pWXiAaHz3yRB9wymYQCwVm/ccT4SWY VJiDSO89cqLUei/EK7ycK1j4vJimemYmtHxiBdJk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Samuel Page , David Heidelberg , Sasha Levin Subject: [PATCH 5.10 19/43] nfc: nci: fix uninit-value in the RF discover/activated NTF handlers Date: Mon, 31 Aug 2026 15:35:27 +0200 Message-ID: <20260831133359.385753214@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260831133358.571886287@linuxfoundation.org> References: <20260831133358.571886287@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Samuel Page [ Upstream commit 8cbe06c1e699c0a165dae5093a2550e65f914818 ] nci_rf_discover_ntf_packet() and nci_rf_intf_activated_ntf_packet() each parse a notification into an on-stack struct (nci_rf_discover_ntf / nci_rf_intf_activated_ntf) that is not initialised. The RF technology-specific parameters are only extracted when rf_tech_specific_params_len is non-zero, so a notification that reports a zero length leaves the rf_tech_specific_params union uninitialised - and both handlers then pass it to nci_add_new_protocol(), which reads it: - discover: nci_add_new_target() -> nci_add_new_protocol(); - activated: nci_target_auto_activated() -> nci_add_new_protocol(). nci_add_new_protocol() uses nfca_poll->nfcid1_len as both a branch condition and a memcpy() length and copies nfcid1/sens_res/sel_res into ndev->targets, which is later exposed to user space via NFC_CMD_GET_TARGET. BUG: KMSAN: uninit-value in nci_add_new_protocol+0x624/0x6c0 nci_add_new_protocol+0x624/0x6c0 nci_ntf_packet+0x25b2/0x3c30 nci_rx_work+0x318/0x5d0 process_scheduled_works+0x84b/0x17a0 worker_thread+0xc10/0x11b0 kthread+0x376/0x500 Local variable ntf.i created at: nci_ntf_packet+0xbc2/0x3c30 Zero-initialise both on-stack notifications so the union reads back as zero when no technology-specific parameters are present. Fixes: 019c4fbaa790 ("NFC: Add NCI multiple targets support") Fixes: e8c0dacd9836 ("NFC: Update names and structs to NCI spec 1.0 d18") Link: https://lore.kernel.org/netdev/20260623172109.1105965-2-horms@kernel.org/ Cc: stable@vger.kernel.org Assisted-by: Bynario AI Signed-off-by: Samuel Page Link: https://patch.msgid.link/20260626090301.2139500-1-sam@bynar.io Signed-off-by: David Heidelberg Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- net/nfc/nci/ntf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/net/nfc/nci/ntf.c +++ b/net/nfc/nci/ntf.c @@ -310,7 +310,7 @@ void nci_clear_target_list(struct nci_de static void nci_rf_discover_ntf_packet(struct nci_dev *ndev, struct sk_buff *skb) { - struct nci_rf_discover_ntf ntf; + struct nci_rf_discover_ntf ntf = {}; __u8 *data = skb->data; bool add_target = true; @@ -517,7 +517,7 @@ static void nci_rf_intf_activated_ntf_pa struct sk_buff *skb) { struct nci_conn_info *conn_info; - struct nci_rf_intf_activated_ntf ntf; + struct nci_rf_intf_activated_ntf ntf = {}; __u8 *data = skb->data; int err = NCI_STATUS_OK;