From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A74E33A9E8; Mon, 31 Aug 2026 13:45:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788183919; cv=none; b=ZsBX9E9AGom7uYYf29LaZqelWNPjwVYawoEM+xuRem+6bBI12fqKswEUiffM0OKA3DHxQkt/HivBhvP33HBGiA6j7Cj5frJU98zjy/y4skIQKw8m2wvcvFsC3iH6AWL3ZThinK21HqSsuwOF1cXMclcxNDQu/FrsLo0y/FZK5u8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788183919; c=relaxed/simple; bh=neYWFIJ7gGOkjRNxYnZAUHclVYEBSM2MVFsGlmAvOE4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cEy5WWtYQjUaTfqhZF2HKCmxEvMp6lv/JXWEGcKzcEY4wYZ9pyy7XLEo+i+ojIYbL/9tjhigH2NQjfbuXsRTGhaBWw8GP7R3PITKcYrybiw3bDqefZDBA4ZfS511ww28HLMpVTH/82jVLCdQZRqya4lZFXx129O4Cl0yoTglwuE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=VAiHlFSM; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="VAiHlFSM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7567A1F00A3F; Mon, 31 Aug 2026 13:45:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788183918; bh=+PE1br/EDorTMwBuxwhgUC7CAyxxHoGx8rw5uM48SZI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=VAiHlFSM/GHEp2uuxTdzNUXsNjwrqd89A6hXAbhEJIua0e5OEx/nzMGRVYm+isOoI o5WXRifhZ4K/c8Qb0em4K8PkgOh+wLxe8ZEbZxSpqKZPcu/2sTgBr22IaXqa6KJEeZ bWW1+pWyGp5x1K1PRmWP+Fd+RyIxdHiHgnWnAhpM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Bryam Vargas , Stephen Smalley , Paul Moore , Wentao Guan , Sasha Levin Subject: [PATCH 6.18 11/83] selinux: reject a permission value exceeding the class permission count Date: Mon, 31 Aug 2026 15:33:47 +0200 Message-ID: <20260831133359.734622868@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260831133359.207714926@linuxfoundation.org> References: <20260831133359.207714926@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Bryam Vargas [ Upstream commit d14b5d0e97fccd27974fedc03b903408872907fd ] perm_read() bounds a permission value by SEL_VEC_MAX but never by the nprim of the owning class or common, which is taken verbatim from the policy image. security_get_permissions() then writes perms[value - 1] into an nprim-sized kcalloc() array, so a class declaring fewer permissions than its largest permission value drives an out-of-bounds heap write. The top-level symbol tables are validated this way; the nested per-class permission table is not. Reject a permission whose value exceeds nprim, which is already set when perm_read() runs. Well-formed policies are unaffected. Cc: stable@vger.kernel.org Fixes: 55fcf09b3fe4 ("selinux: add support for querying object classes and permissions from the running policy") Signed-off-by: Bryam Vargas Acked-by: Stephen Smalley [PM: tweak comment for line length] Signed-off-by: Paul Moore (cherry picked from commit d14b5d0e97fccd27974fedc03b903408872907fd) Signed-off-by: Wentao Guan Signed-off-by: Sasha Levin --- security/selinux/ss/policydb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c index b87a512446197..926dae3731a0d 100644 --- a/security/selinux/ss/policydb.c +++ b/security/selinux/ss/policydb.c @@ -1160,6 +1160,9 @@ static int perm_read(struct policydb *p, struct symtab *s, struct policy_file *f rc = -EINVAL; if (perdatum->value < 1 || perdatum->value > SEL_VEC_MAX) goto bad; + /* indexes an nprim-sized array in security_get_permissions() */ + if (perdatum->value > s->nprim) + goto bad; rc = str_read(&key, GFP_KERNEL, fp, len); if (rc) -- 2.53.0