From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3A7548D880; Mon, 31 Aug 2026 14:07:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788185230; cv=none; b=ncGIsaiS71zQyx9MJ99rvTa8y9/xne9rFQEtLHVkAipMzWG3wfJ2WkcYuH9P6awMvcBHavkhBfPEEvecJMo0uPE2nwF8tvzG6Uqg7c4vDTzfvGQ1RuAHNo+gbxNCARPp8BZC4JUS3QEQo4Jm0cuAGJFjvTO0Nmb7yjO6o+uhcgg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788185230; c=relaxed/simple; bh=tjjrfPuwjrIyFD5zLJPMA+5kPZA12DgXx3+AhQzW2Sg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EiLf32Q+mztQYQ3+6sPWvtyH2R50bus9RyBuLkhbAmwemYAnic1OPvhsWhMDaJ+CUZ1zorLrxrIAPDmgsI0g4VCRTzu16bx2/OnVjRXKo0kt0tQr5XWLSS1zo+BHT8cx2PEFv4jQOQps/8qI8EJ8JwwLdfSvp/FL1Mq/6tz7XlY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=MvEZAzAr; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="MvEZAzAr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49B861F00A3D; Mon, 31 Aug 2026 14:07:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788185228; bh=NIbHIkyPxAAFjlxnR6KiFB4q7ZyFDmGAnzivGcEoVhs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=MvEZAzAriAAUUEfsyqpdLcyeCFKAHKT90lfzOYiKPd5cnwjxfuZbmXgMlo4VLn2q7 jQon8TzyfW0BsiyrlI8iC+8QyI0hoHiiun0McFBgEsTzth7oQq6rOL7Pu//oLvQtDi 1ML9xVk5OgW4asINVmAtBLXIzH8affDzI2nSOK1g= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, zdi-disclosures@trendmicro.com, Sabrina Dubroca , Breno Leitao , Steffen Klassert Subject: [PATCH 5.10 28/43] xfrm: espintcp: fix UAF during close Date: Mon, 31 Aug 2026 15:35:36 +0200 Message-ID: <20260831133359.883892832@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260831133358.571886287@linuxfoundation.org> References: <20260831133358.571886287@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Sabrina Dubroca commit deb232e884877bf10b4ce2580909eedec986c284 upstream. ZDI reported and analyzed a race condition during close for espintcp sockets: espintcp_close() frees emsg->skb via kfree_skb() without holding any socket lock. Concurrently, the xfrm_trans_reinject work queue invokes esp_output_tcp_finish() -> espintcp_push_skb() -> espintcp_push_msgs() -> skb_send_sock_locked(), which reads the same skb as a data source. Fix this by adding a synchronize_rcu() call after resetting sk_prot, since esp_output_tcp_finish() runs under RCU and won't use a socket with sk_prot == &tcp_prot. Simply taking the socket lock in espintcp_close() could lead to leaks, if esp_output_tcp_finish() re-adds an skb in the slot we just freed. After this, the existing barrier() is no longer needed. Cc: stable@vger.kernel.org Fixes: e27cca96cd68 ("xfrm: add espintcp (RFC 8229)") Reported-by: zdi-disclosures@trendmicro.com Signed-off-by: Sabrina Dubroca Reviewed-by: Breno Leitao Signed-off-by: Steffen Klassert Signed-off-by: Greg Kroah-Hartman --- net/xfrm/espintcp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/net/xfrm/espintcp.c +++ b/net/xfrm/espintcp.c @@ -506,7 +506,8 @@ static void espintcp_close(struct sock * strp_stop(&ctx->strp); sk->sk_prot = &tcp_prot; - barrier(); + + synchronize_rcu(); cancel_work_sync(&ctx->work); strp_done(&ctx->strp);