From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 091904A13B0; Mon, 31 Aug 2026 14:08:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788185288; cv=none; b=OwwoULXxjZopjZWRjm5wYSFTvZKsUC9xJ1jyWLYOCm3+W2NSMepjUC27ikw8QVfH3ZJy4Kg0sqEK8ypJnXv8A6CPo9TQ4CSPTpt/mrh/ZtS6rkwpdWUz6O40Hj5od7SLqA9XEKXe20LLiSX2mJrNUOfCqhJAGHHh8YRbGCyfTqM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788185288; c=relaxed/simple; bh=16pAtrQz088M+DXE2D8zZvDDgErC2kRb8L2Fqlxhnq4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eBqmvzXWpkTMNlobmA6Q4E0iLv8W9jGhm8tFfKtTiBFVl/bnI8XWgFKSuJLdK6UxnOHqsTUgx34fLeeZLBJjlCe9XYYgX5s4vYcCByMFACs+6FcQNkWa7a7oFyw5RWWKOMcz61FwQaKll0u25cm7bws0cP+NDa1akCbULb5Hblk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=jbKptzbH; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="jbKptzbH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53B1D1F000E9; Mon, 31 Aug 2026 14:08:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788185285; bh=dXqIEiKJKlN3+HBXKg+98dzJTndU6vfxlG8g5UucReU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=jbKptzbHCFt6yGbSAK/H/Gc+lfzQHXekLVMP30eywGHZB5knfBwFiBGCii/MKVxIo 8m0X3lkQlcdrgjg1Qkbdknv6dLM3/fqMc5/jNaHR196O5KZBREU0XpsevHC5v2KQzZ Nz9KhvI5NmYX9hCql7CJZnGyY6l3qbcxWs+VrxjQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+3b514b87202742f22c44@syzkaller.appspotmail.com, Johan Hovold Subject: [PATCH 5.10 41/43] USB: serial: spcp8x5: drop broken carrier detect support Date: Mon, 31 Aug 2026 15:35:49 +0200 Message-ID: <20260831133400.676125932@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260831133358.571886287@linuxfoundation.org> References: <20260831133358.571886287@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold commit d37186bd95a07e334447f47274a38a311dad2172 upstream. The driver does not support modem status notifications and instead used to fetch the modem status once at open() and subsequently operate on and report stale state. As part of fixing this, a call to fetch the status was added to carrier_raised(), which does not work as that callback must not sleep (e.g. unlike tiocmget()). Drop the broken carrier detect support. Fixes: e1ed212d8593 ("USB: spcp8x5: add proper modem-status support") Cc: stable@vger.kernel.org # 3.10 Reported-by: syzbot+3b514b87202742f22c44@syzkaller.appspotmail.com Link: https://lore.kernel.org/all/6a73cea2.01d0871a.3a0d52.000d.GAE@google.com Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman --- drivers/usb/serial/spcp8x5.c | 13 ------------- 1 file changed, 13 deletions(-) --- a/drivers/usb/serial/spcp8x5.c +++ b/drivers/usb/serial/spcp8x5.c @@ -249,18 +249,6 @@ static void spcp8x5_set_work_mode(struct dev_err(&port->dev, "failed to set work mode: %d\n", ret); } -static int spcp8x5_carrier_raised(struct usb_serial_port *port) -{ - u8 msr; - int ret; - - ret = spcp8x5_get_msr(port, &msr); - if (ret || msr & MSR_STATUS_LINE_DCD) - return 1; - - return 0; -} - static void spcp8x5_dtr_rts(struct usb_serial_port *port, int on) { struct spcp8x5_private *priv = usb_get_serial_port_data(port); @@ -472,7 +460,6 @@ static struct usb_serial_driver spcp8x5_ .num_bulk_out = 1, .open = spcp8x5_open, .dtr_rts = spcp8x5_dtr_rts, - .carrier_raised = spcp8x5_carrier_raised, .set_termios = spcp8x5_set_termios, .init_termios = spcp8x5_init_termios, .tiocmget = spcp8x5_tiocmget,