From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 949B352A2E0; Mon, 31 Aug 2026 13:44:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788183878; cv=none; b=f5NYnX/XJmeCxqVGaXNoxLJG0rwRWEoUbdzlPeBYTLebvuHDYqtXucF4qSVhLrg4MfXaUE/Kj1lreDOO+Uyo6MEp51mt7N1MKNqoU1B6mSmwQYB98c/tXZoTaiZ5Ykv4AqkJZRB/LJMyJNUKRZ1eej7Qa1FMdOxJl29lPsIeBEA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788183878; c=relaxed/simple; bh=Z4gLbiXgnL+KRGtKjGvcPlnjYU9cFefnmAgTO8hCVdg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CpK+ua9uAuELEg0/ff6fQCSJdPObPbvojGbLdqKtxgWuCWxajb2ZTTFejVYbYDS+Wg0DBupWa3fBHCAbDo0aajdpFxLotCGy+J/ktE+dynWgTK5fKV8uO0IFEe+VlnH4+ehXzddTiEMdYvhEsWvGrVgq+egXFMOERQg47viV5q8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=m2Lq16nm; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="m2Lq16nm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFC5C1F00A3E; Mon, 31 Aug 2026 13:44:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788183876; bh=/okE0y8/SgjMi9XWhqGIscBScG8lQmk51Pr0vuXU5UQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=m2Lq16nm2tZNyp8GA0z6x73bPUsGkuyTvWzlOd1X5Agnk4aL+81d7RSySqP8Vf722 HaRWO9yGC/jsTxH4shJ2ytRJk09u1D1tRurA/lemEFJlWnDqhStNJzk+uruBoxRN6B zkpUrAFvhw1aOGZcuQNcT+lpB3+Mwc6K1gpnOi1g= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, syzbot+7e1e5911f9eac50bedc7@syzkaller.appspotmail.com, Aleksandr Nogikh , syzbot@syzkaller.appspotmail.com Subject: [PATCH 7.1 27/76] usb: usbtest: disable dynamic ID support Date: Mon, 31 Aug 2026 15:33:59 +0200 Message-ID: <20260831133400.707801958@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260831133359.185608553@linuxfoundation.org> References: <20260831133359.185608553@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Aleksandr Nogikh commit 00e2071f6d5621a5ddea311a5e6b143ae6e474af upstream. The usbtest driver relies on the driver_info field of struct usb_device_id to point to a valid struct usbtest_info descriptor. This structure contains essential test configurations, such as endpoint addresses and test modes, which are required during probe. When a user dynamically adds a new device ID via the sysfs new_id interface without specifying a reference device, the USB core initializes driver_info to 0 (NULL). When a matching device is subsequently probed, usbtest_probe() unconditionally casts driver_info to a struct usbtest_info pointer and dereferences it, leading to a NULL pointer dereference crash: Oops: general protection fault, probably for non-canonical address 0xdffffc0000000001: 0000 [#1] SMP KASAN NOPTI KASAN: null-ptr-deref in range [0x0000000000000008-0x000000000000000f] RIP: 0010:usbtest_probe+0x3b9/0x1280 drivers/usb/misc/usbtest.c:2822 Because usbtest strictly requires pre-defined usbtest_info descriptors to function, dynamic ID binding via sysfs is fundamentally unsupported for this driver. Fix this by setting .no_dynamic_id = 1 on usbtest_driver. This instructs the USB core to skip creating the new_id and remove_id sysfs interfaces for usbtest, preventing invalid dynamic ID entries from being created. Cc: stable@vger.kernel.org Reported-by: syzbot+7e1e5911f9eac50bedc7@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=7e1e5911f9eac50bedc7 Signed-off-by: Aleksandr Nogikh Tested-by: syzbot@syzkaller.appspotmail.com Link: https://patch.msgid.link/20260806152651.2370795-1-nogikh@google.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/usbtest.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/usb/misc/usbtest.c +++ b/drivers/usb/misc/usbtest.c @@ -3054,6 +3054,7 @@ static struct usb_driver usbtest_driver .disconnect = usbtest_disconnect, .suspend = usbtest_suspend, .resume = usbtest_resume, + .no_dynamic_id = 1, }; /*-------------------------------------------------------------------------*/