From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 249825632BF; Mon, 31 Aug 2026 13:47:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788184069; cv=none; b=eKi9UsUfuxaCKQCoHIx7uGbCDwQHiJtoKo94cjPOzkT/NLCscU5r+TfIDv2wUEfr59yaeUXKWW09s5zZHl60vmeYuxh9Uhpzuk6QiQtfXzLNy1IvO3mcap9UOt/KtEakSHtPzrVge5+j//c11GJucXMeovoBgywyTJ6F1q+hRaU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788184069; c=relaxed/simple; bh=JegjMDWVwu1AIvlapiKfoHG8AMQfZyD1iWlDOfVFg9o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KlSv3YnQIdqdmszbV22reYgyX1001s5yVUDMdB1fo4RcJmkn3qvkRMsocb3JT3Iar1fY7HWR6HF3n3Ze504bScJ+KZBMFS8ZpFB2rKKWcK/5qJfVlj9X42zHT4BOp/4ZbGtEQjM5Ki1ixNoDzRZvwR4voded7XQzXWAUP+t6abM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=FHp+2cED; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="FHp+2cED" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 837B61F000E9; Mon, 31 Aug 2026 13:47:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788184068; bh=gIGIKcVxnIggR3moy9SychBsZ8KlCnC/d/BmvUtNa9Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=FHp+2cEDIfB2q8CU4M2GgtY944tLQPg6UQYBEHgBto2Z78egW3YUEAX2cgfLw5JNp AIHCWdG148YPfyyO8ZokSENEW39hCR98U24VNGjzjcUAQb2lyXKc4LDa3cLUKMmALD KhaiXEk1mVnLyAppP3VpFrl056gyR3eMRu0e468U= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Mathias Nyman , Lucas De Marchi Subject: [PATCH 6.18 35/83] xhci: dbgtty: Fix unregister on tty_alloc_driver() failure Date: Mon, 31 Aug 2026 15:34:11 +0200 Message-ID: <20260831133401.248486164@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260831133359.207714926@linuxfoundation.org> References: <20260831133359.207714926@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Lucas De Marchi commit 25b8dfc13495a6c1cf4abacc8ef20196c7f20e5c upstream. Make sure to set dbc_tty_driver to NULL to match the check in dbc_tty_exit(). For that, make detached error handling path common to the other branch in the same function. Fixes: 4521f1613940 ("xhci: dbctty: split dbc tty driver registration and unregistration functions.") Cc: stable@vger.kernel.org # v5.10 Cc: Mathias Nyman Cc: Greg Kroah-Hartman Signed-off-by: Lucas De Marchi Signed-off-by: Mathias Nyman Link: https://patch.msgid.link/20260806142113.2436238-9-mathias.nyman@linux.intel.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/host/xhci-dbgtty.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) --- a/drivers/usb/host/xhci-dbgtty.c +++ b/drivers/usb/host/xhci-dbgtty.c @@ -628,8 +628,8 @@ int dbc_tty_init(void) dbc_tty_driver = tty_alloc_driver(64, TTY_DRIVER_REAL_RAW | TTY_DRIVER_DYNAMIC_DEV); if (IS_ERR(dbc_tty_driver)) { - idr_destroy(&dbc_tty_minors); - return PTR_ERR(dbc_tty_driver); + ret = PTR_ERR(dbc_tty_driver); + goto fail; } dbc_tty_driver->driver_name = "dbc_serial"; @@ -649,12 +649,18 @@ int dbc_tty_init(void) ret = tty_register_driver(dbc_tty_driver); if (ret) { pr_err("Can't register dbc tty driver\n"); - tty_driver_kref_put(dbc_tty_driver); - idr_destroy(&dbc_tty_minors); - dbc_tty_driver = NULL; + goto fail_put; } return ret; + +fail_put: + tty_driver_kref_put(dbc_tty_driver); +fail: + idr_destroy(&dbc_tty_minors); + dbc_tty_driver = NULL; + + return ret; } void dbc_tty_exit(void)