From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D062F4A4C02; Mon, 31 Aug 2026 13:43:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788183832; cv=none; b=IMrfAD/Gy/5ChCLZS/iVS040wPCpA+bOvmWosKN/lUgWGHCQ1y9V424M/4CoLNfjIkUbAJijMK2t20I4UIXnx2Jv0+9E85jOXc6pz8c/lig1jNW2142OC2d/IHEOQSDQtvihsfNV5/BwtEn/Ii90VtsKRRhRPrjfrjRG+XXHNag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788183832; c=relaxed/simple; bh=QH/mkhDPTnFwWrwF4lWxkNGQkwRNztu7+q6TlXSszZQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ASuXzb0X4GTOCT+DbuzgYwECR9NypWcfkjUUmeEgwQmnY9ykb1J8zBnbV2goz/u6DHS34rT4xggo3IFME/oR1UwCGZT6tQGWqVCoO6HZYwmy8/liGO9baYFtg6IBiaC8Gdcq++fn5fBakN0NYmo+AP5DWlKLwACtdqWQkWYrQn4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=wOz+9g4i; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="wOz+9g4i" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 377CD1F00A3F; Mon, 31 Aug 2026 13:43:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788183830; bh=JhH9naiko2dpx5dnnFEWaAUbWfsnBiT+4++WVutwPWs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=wOz+9g4iadJFw+1eX3VAaEH6hIphTkX0QIF6XbsQTHk6uW5thnGgIC+t6PgUiNmIB +IE+KZPkC+qggaG24H5CPCPZcMFhY4YM2PaOsZBD8x7wtvSw9cwlQgsQgXUJ/4rXog x28Xr6UgaU1utDCpQoSRyZ2+d5GlJ5nQdjrT+QZ8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Bryam Vargas , "Michael S. Tsirkin" Subject: [PATCH 7.1 56/76] crypto: virtio - bound the akcipher result length Date: Mon, 31 Aug 2026 15:34:28 +0200 Message-ID: <20260831133402.361243273@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260831133359.185608553@linuxfoundation.org> References: <20260831133359.185608553@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.1-stable review patch. If anyone has any objections, please let me know. ------------------ From: Bryam Vargas commit f77a956f6a19f9463ef1527c9d0cda50dded6b92 upstream. virtio_crypto_dataq_akcipher_callback() sets the result length from the device-reported response length without bounding it to the destination buffer, which was allocated for the original request length. sg_copy_from_buffer() then reads that many bytes from the destination buffer; a backend reporting a larger length over-reads adjacent kernel heap into the caller's scatterlist (an out-of-bounds read). Clamp the reported length to the originally requested destination length. A conforming device reports no more than that, so valid results are unaffected. Fixes: a36bd0ad9fbf ("virtio-crypto: adjust dst_len at ops callback") Cc: stable@vger.kernel.org Signed-off-by: Bryam Vargas Message-ID: <20260622-b4-disp-3a2c09a8-v2-1-d1a809281db4@proton.me> Signed-off-by: Michael S. Tsirkin Signed-off-by: Greg Kroah-Hartman --- drivers/crypto/virtio/virtio_crypto_akcipher_algs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/crypto/virtio/virtio_crypto_akcipher_algs.c +++ b/drivers/crypto/virtio/virtio_crypto_akcipher_algs.c @@ -88,7 +88,8 @@ static void virtio_crypto_dataq_akcipher } /* actual length may be less than dst buffer */ - akcipher_req->dst_len = len - sizeof(vc_req->status); + akcipher_req->dst_len = min_t(unsigned int, len - sizeof(vc_req->status), + akcipher_req->dst_len); sg_copy_from_buffer(akcipher_req->dst, sg_nents(akcipher_req->dst), vc_akcipher_req->dst_buf, akcipher_req->dst_len); virtio_crypto_akcipher_finalize_req(vc_akcipher_req, akcipher_req, error);