From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F4C9339872; Fri, 4 Sep 2026 06:10:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788502215; cv=none; b=ooD/vCET1j8iHfuOvTV/v99CQ1AUQ+lzg6X02hQ1XOUk2w0ATLJvbOUu0CzmoNStm4wWQawxI3ymIe1ZR/Qt3mkYA5jVFbDIqy+maTjTf50DGv6yluT3GYpqSNStdCqaRPdT8c6ZWDRBPSekoNJ67vjfHKY5w3mmZUYQQR7NCyo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788502215; c=relaxed/simple; bh=UCOIwL204psI8mnIvUyQnJXmSAjLT7bBpWHRcCUKKVM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LPE9PfcPjh484XjtEh+Ra7OReAvKv/3HC27P3jv7cGhlfXzq8Ds8Wi9NI8LMPzyvB+/Q2V0zAwDWvKhDXKHFUXNhjh5Bd737ZrBr7OdSkhcwhFyDdujvDX6ObJLliAGt1SBjN8PScKoCVH5z7pb95QL7h/4I5LXFkBIQMGcNqHg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=W0QysCld; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="W0QysCld" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87EEF1F00A3D; Fri, 4 Sep 2026 06:10:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788502214; bh=pthEATIYe1IKgYW23o0IQpTvvNV+vPV/KgoabHRrFiY=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=W0QysCldffm69u/o+02U40HycaYYZiO5qQvhyR720B76g3H9fmK7xHX390FHgV7Kw ojLmxmvE0N3h8K53nLnCw2glDB1FgnjAKyl/py9tcu5VbGX1ByCt2BGIJYBXq9fJZz DpawJmvDMWkokjrTlh5ZNIe2IQmdtTXLrani4ACg= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Haoxiang Li , Srinivas Pandruvada , Jiri Kosina Subject: [PATCH 6.12 127/403] HID: sensor: custom: Fix field sysfs group cleanup on failure Date: Fri, 4 Sep 2026 06:58:50 +0200 Message-ID: <20260904045737.726588877@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260904045734.806166532@linuxfoundation.org> References: <20260904045734.806166532@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Haoxiang Li commit 3789d0802ddb4b3be04062caf4bfadd23496e9a7 upstream. hid_sensor_custom_add_attributes() creates one sysfs group for each custom sensor field. If sysfs_create_group() fails after some groups have already been created, the function returns the error without removing the previously created groups. Add a local unwind path to remove the groups that were already created. With enable_sensor exposed only after the field attributes are ready, this path can free sensor_inst->fields without leaving enable_sensor able to access pointers into that array. Fixes: 4a7de0519df5 ("HID: sensor: Custom and Generic sensor support") Cc: stable@vger.kernel.org Signed-off-by: Haoxiang Li Acked-by: Srinivas Pandruvada Signed-off-by: Jiri Kosina Signed-off-by: Greg Kroah-Hartman --- drivers/hid/hid-sensor-custom.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) --- a/drivers/hid/hid-sensor-custom.c +++ b/drivers/hid/hid-sensor-custom.c @@ -609,7 +609,7 @@ static int hid_sensor_custom_add_attribu &sensor_inst->fields[i]. hid_custom_attribute_group); if (ret) - break; + goto err_remove_groups; /* For power or report field store indexes */ if (sensor_inst->fields[i].attribute.attrib_id == @@ -621,6 +621,13 @@ static int hid_sensor_custom_add_attribu } return ret; + +err_remove_groups: + while (--i >= 0) + sysfs_remove_group(&sensor_inst->pdev->dev.kobj, + &sensor_inst->fields[i].hid_custom_attribute_group); + kfree(sensor_inst->fields); + return ret; } static void hid_sensor_custom_remove_attributes(struct hid_sensor_custom *