From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C164378838; Fri, 4 Sep 2026 06:12:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788502358; cv=none; b=NJyXResg0RIpFnSGNbTw0cMlXZgJ8DT6V/GmXChH6UcGc8to7P1LEVbWe0unkjXrkx4JOELtX5ZHRs5Ru899dqyfvXs0KPTP/LmuUdjYfCwxyBaISlxk+E+RwqvHNXZUZUf5wZQJS5/8G4J3uvwlDmwjHBk4n6DzflwuJg5SJ1Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788502358; c=relaxed/simple; bh=NPOFnQEQSyubmKPzPoOdThhUmjT12i4Y5VCVQDnGyq4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Xj2Ftqbz9AHBXFG+nTI05WA5n9JzlK2AMS81XsZizU7Gcw8J96ufNJislLRwyH7DR5vfo0qznWltka9pWF91R3xpQZWrEznPZGgCXsVzSfqYp82gPiph1iMsarkcif3rJl9FYnUN3LScIxnQ1RrLej/njBLEy5KgANpmTurV2Xo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=kBeSvwa5; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="kBeSvwa5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82F851F00A3D; Fri, 4 Sep 2026 06:12:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788502357; bh=XHp76tl5QXmEEguhxSFHPyHlNnEvhiwkpfrowlfC5uE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=kBeSvwa5eT+nleUDSYyPdEpzOYbkbMvzDQw456Bnek+fyuYsU88p9jaJtWq06Jsj0 pkriyFUDYkmAXFumhX2DpQKew0hDBdRhwqQ8e+MBUashFm2zVWsLSa2VkZER7kPsJ+ 4GzycNeS5yXdYdX+E9bXY0aqcY+FHs6OA2cwzf/I= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Gongwei Li , Luiz Augusto von Dentz Subject: [PATCH 6.12 177/403] Bluetooth: hci_uart: Fix false success return in hci_uart_setup() Date: Fri, 4 Sep 2026 06:59:40 +0200 Message-ID: <20260904045738.882443639@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260904045734.806166532@linuxfoundation.org> References: <20260904045734.806166532@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Gongwei Li commit a9355799343e10014f2acfd4b6844d2335ecafea upstream. When reading the local version information for vendor detection fails, the error is only printed and 0 is returned, which masks the setup failure from the HCI core. Return PTR_ERR(skb) instead. Fixes: fb2ce8d11f039 ("Bluetooth: hci_uart: Add support for vendor detection flag") Fixes: 82f5169bf3d3b ("Bluetooth: hci_uart: add serdev driver support library") Cc: stable@vger.kernel.org Signed-off-by: Gongwei Li Signed-off-by: Luiz Augusto von Dentz Signed-off-by: Greg Kroah-Hartman --- drivers/bluetooth/hci_ldisc.c | 2 +- drivers/bluetooth/hci_serdev.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- a/drivers/bluetooth/hci_ldisc.c +++ b/drivers/bluetooth/hci_ldisc.c @@ -451,7 +451,7 @@ static int hci_uart_setup(struct hci_dev if (IS_ERR(skb)) { BT_ERR("%s: Reading local version information failed (%ld)", hdev->name, PTR_ERR(skb)); - return 0; + return PTR_ERR(skb); } if (skb->len != sizeof(*ver)) { --- a/drivers/bluetooth/hci_serdev.c +++ b/drivers/bluetooth/hci_serdev.c @@ -221,7 +221,7 @@ static int hci_uart_setup(struct hci_dev if (IS_ERR(skb)) { bt_dev_err(hdev, "Reading local version info failed (%ld)", PTR_ERR(skb)); - return 0; + return PTR_ERR(skb); } if (skb->len != sizeof(*ver))