From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A89C6415B8F; Fri, 4 Sep 2026 05:44:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788500669; cv=none; b=Quh2k4cZHDnbkos/d2qbLukiY3MFrmKIU9jpggHw6lWvLkhQPNeqoppmyFnsd2c3GukHSuYx5uJk9nG8376mKgBy7rnHwKvwI+aDANXjgv58ZbcGV6ntcTEeF3SV8W11l2fPjkYWD5teyv0oXku78H/2ZQXhWMBwhxD/TdH79iM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788500669; c=relaxed/simple; bh=h/cUzy6zXlidNBFpHVAJtS90YB1VBpMkA7nl29PsoSM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=NcBYstFCpizw6JCNV1VAsdYChhduoIwoL3bg1JcKvlUWD7pUGdvBSrxwEoVLug90XlAQI1ExkPkxoDtCTgFU4+vmlXKAmSlD15sF4gvKYwF2QPINVCYnAflsbAzVlcKNOWE0lp6MzLTYgAnjF+qgc3WCdMIWfPb0BpTIV/Xeck4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=NEqRMFst; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="NEqRMFst" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1047D1F00A3D; Fri, 4 Sep 2026 05:44:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788500668; bh=B8/AKwnihMO8I5eieVUFBk4hWQljw8vtgTdm7K5tW+o=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=NEqRMFsti16JKNrI+d71UD9G5Vsw4evbFk7KyydCyLYcVVw1t+glISoLSlWBqB53u GFSNmdCppA9n8hSXZWUOxpNI/eNpp/dxrIQlxQdkNym2tGb3YC3ImQMI94Iw+xVuzy wOyX2jQWthFNGyGEXDwZ56MWCbDX5xUs7XuEGkGk= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Jeff Layton , Chuck Lever Subject: [PATCH 6.18 138/552] nfsd: fix version mismatch loops in nfsd_acl_init_request() Date: Fri, 4 Sep 2026 06:54:55 +0200 Message-ID: <20260904045751.595344278@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260904045747.813364717@linuxfoundation.org> References: <20260904045747.813364717@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jeff Layton commit 9bc761051dcd9a4a8b59e64b2b185172d13c716d upstream. The loops that compute the supported version range for PROG_MISMATCH test nfsd_support_acl_version(rqstp->rq_vers) instead of nfsd_support_acl_version(i), so every iteration fails and the function returns rpc_prog_unavail instead of rpc_prog_mismatch. Replace rqstp->rq_vers with the loop variable i, matching the pattern used by the sibling nfsd_init_request() function. Fixes: e333f3bbefe3 ("nfsd: Allow containers to set supported nfs versions") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Jeff Layton Link: https://patch.msgid.link/20260611-nfsd-testing-v2-9-5b90e276f2d9@kernel.org Signed-off-by: Chuck Lever Signed-off-by: Greg Kroah-Hartman --- fs/nfsd/nfssvc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/fs/nfsd/nfssvc.c +++ b/fs/nfsd/nfssvc.c @@ -835,7 +835,7 @@ nfsd_acl_init_request(struct svc_rqst *r ret->mismatch.lovers = NFSD_ACL_NRVERS; for (i = NFSD_ACL_MINVERS; i < NFSD_ACL_NRVERS; i++) { - if (nfsd_support_acl_version(rqstp->rq_vers) && + if (nfsd_support_acl_version(i) && nfsd_vers(nn, i, NFSD_TEST)) { ret->mismatch.lovers = i; break; @@ -845,7 +845,7 @@ nfsd_acl_init_request(struct svc_rqst *r return rpc_prog_unavail; ret->mismatch.hivers = NFSD_ACL_MINVERS; for (i = NFSD_ACL_NRVERS - 1; i >= NFSD_ACL_MINVERS; i--) { - if (nfsd_support_acl_version(rqstp->rq_vers) && + if (nfsd_support_acl_version(i) && nfsd_vers(nn, i, NFSD_TEST)) { ret->mismatch.hivers = i; break;