From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25B69377EDC; Fri, 4 Sep 2026 05:47:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788500840; cv=none; b=mZfR4FgMsQdY7X7gOjm+bo/YnIPrheB5cDdsDabMAtbSvrAu9VBa8XFq0MJdY/oyXtFULnMXp1bnKLrnmUe8HerO7Eiyvfwlo1kTdHo2gfC9OXUNwUD7L+io0+7xnWDvUm0Fircjugw2OC1wsmk4tEfanUtYz2diGYAl8uBETIo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788500840; c=relaxed/simple; bh=B73Zh2+Q+XrdBIcEz+06HqePd/erNQlR1vC2InLpOQY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uiDyO0dycR2DnKX5CB5ossW8rLW4p0TSlnglS2ZI10QkApxeGn9BM3wcOgiI+MOFl+wlHAaYFSPrWR27WnJUh2rJ+PapggQpPDWieyLceARtVu0rmT4J2Tg3sdS9UW704V6yQHP/SiheVXC5cK297knkCJqFQXsvIbFtoWdn7ZU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=EOsQz9je; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="EOsQz9je" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E0091F00A3D; Fri, 4 Sep 2026 05:47:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788500839; bh=voUFtRyyUR8rG3jzZCFkYXthzNEPIVDbavDnn1LKFDU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=EOsQz9jeP6LygiCmkeuoUYZsHX2uJYPTAXy+mSY96NnDDH6M3fcx/X18xyvoRj6lW MNxaDv4Od4dyT8om1ckWgAFdJepeanc/R9eeL8z/oNx5rf3aaAoknjFS8rz65I/VP/ NHVYApGcsgjGtkt4GlOenCbm6Kb52B6HcbxY3vpQ= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yichong Chen , Tyler Hicks Subject: [PATCH 6.18 197/552] ecryptfs: release message context on send failure Date: Fri, 4 Sep 2026 06:55:54 +0200 Message-ID: <20260904045753.568089290@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260904045747.813364717@linuxfoundation.org> References: <20260904045747.813364717@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yichong Chen commit 219644a3ad5518217b2d62cad6d2c36a2308c949 upstream. ecryptfs_send_message_locked() moves a message context from the free list to the allocated list before sending the request to the userspace daemon. If ecryptfs_send_miscdev() fails, the context is left on the allocated list and cannot be reused. Move it back to the free list on failure and clear the caller's pointer. Fixes: f66e883eb618 ("eCryptfs: integrate eCryptfs device handle into the module.") Cc: Signed-off-by: Yichong Chen Signed-off-by: Tyler Hicks Signed-off-by: Greg Kroah-Hartman --- fs/ecryptfs/messaging.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) --- a/fs/ecryptfs/messaging.c +++ b/fs/ecryptfs/messaging.c @@ -285,9 +285,16 @@ ecryptfs_send_message_locked(char *data, mutex_unlock(&ecryptfs_msg_ctx_lists_mux); rc = ecryptfs_send_miscdev(data, data_len, *msg_ctx, msg_type, 0, daemon); - if (rc) + if (rc) { printk(KERN_ERR "%s: Error attempting to send message to " "userspace daemon; rc = [%d]\n", __func__, rc); + mutex_lock(&ecryptfs_msg_ctx_lists_mux); + mutex_lock(&(*msg_ctx)->mux); + ecryptfs_msg_ctx_alloc_to_free(*msg_ctx); + mutex_unlock(&(*msg_ctx)->mux); + mutex_unlock(&ecryptfs_msg_ctx_lists_mux); + *msg_ctx = NULL; + } out: return rc; }