From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE86D3E7631; Fri, 4 Sep 2026 05:47:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788500865; cv=none; b=SYDt750Z7vuGHCpFI6XnUqYCcCaZFk4JaR0U/8yIV5180HNSEggJythhjjfS1k20hmBkZsJ6Vv1EFSSy/GJ6xw0OiNSb+t8BtRvKKYxgwHnFY89KnKF0kKn515t4CV4lh0/07ucis+rY7M3Ltiw5hrKofFscod6Ks9ey3UiUsMo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788500865; c=relaxed/simple; bh=u+mMTu6+vs65DXCPc1KOgVyHCGAE5Lxk1fqV+Uo3tR4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=s1CHwlgvD7eihBARY5pmH/iAL1jy6bEiZfQ2LG2EjHp/GsaHgONtZSigt+mU+vxiWqMD9osAO2f2fr0GdACSIpNxJzoRd0YuuScSAmNKkyIHoYtiirR/bM1Oxq64h/9X0ZDd3y/ef3zchTa9qJLXAI4fTkSow1n41ZLkAO2XsPk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=a15fd4nw; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="a15fd4nw" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 148A91F00A3D; Fri, 4 Sep 2026 05:47:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788500864; bh=eExaGaLlZfTQ6HjNCM2uep35UedBpNf4PVHizPpW9q8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=a15fd4nwvGsY98IMS0sW/PoCIXvLd+km93EoqI7kBSl8H5rFi40O1hmXrtXls1/Fz DgSIIjyV4om1eCbfytCY9xGUPZBHpp5DxDsrrbGknJvnMcDywYDDSIaH9gpMxrsSeZ 6gbFUl1zzz+X8QHV0YETODQ0iZxbanWZ4qnjx2Jc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ijae Kim , Myeonghun Pak , Helge Deller Subject: [PATCH 6.18 205/552] fbdev: uvesafb: unregister connector callback on init failure Date: Fri, 4 Sep 2026 06:56:02 +0200 Message-ID: <20260904045753.908223397@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260904045747.813364717@linuxfoundation.org> References: <20260904045747.813364717@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Myeonghun Pak commit de8db23aa7c337e606fca9faf48b3ba72968597a upstream. uvesafb_init() registers the v86d connector callback before registering the platform driver. If platform_driver_register() fails, the function returns the error directly and leaves the connector callback registered. The later platform-device failure path already unregisters the callback. Add the same cleanup before the final return when platform-driver registration fails. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: 8bdb3a2d7df4 ("uvesafb: the driver core") Cc: stable@vger.kernel.org Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak Signed-off-by: Helge Deller Signed-off-by: Greg Kroah-Hartman --- drivers/video/fbdev/uvesafb.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/video/fbdev/uvesafb.c +++ b/drivers/video/fbdev/uvesafb.c @@ -1910,6 +1910,8 @@ static int uvesafb_init(void) err = 0; } } + if (err) + cn_del_callback(&uvesafb_cn_id); return err; }