From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBC1B2F9DA1; Fri, 4 Sep 2026 05:51:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788501089; cv=none; b=CvwwLuYCvHwS3oGmduhp2YUc7BvYYXjvup8ftlkDaA9y42C7mFYuN7tvpq+VDesyux/FhzkZhdh6oC1wFqxka03J7+oibLwN0wqyQQU0ut1bkOIIz0fB9E8+jivOl42rE2xlvBVXiV4qyFmcBb/0mcd7M2qz0m9phQOi4pzbD9U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788501089; c=relaxed/simple; bh=peKqbCg3JSQkdMEAmxmb3ptp7SsncEbIo/c05Gonk1c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=B2ESHEvPHZDuAGUcMDAnxDLSaaWnznWEWVa8q7VAkXpibIQOIrL5UBt1PxOGIM09wzzkK4MhZaLk43Z4vCCXXkGdAvhVqbnp72AVZZwa9DLquuIIoobeQlRXo+xZrK6St4Hx+yFR8NrmMJ3sDdZSrEg6PqN4+1/UHimf5lvKrI0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=I1j58CIf; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="I1j58CIf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39B2C1F00A3D; Fri, 4 Sep 2026 05:51:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788501087; bh=1XUR7qOb2jQMjeYJIJhFT7UdtZCFteLEtfsnX4JT+VQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=I1j58CIfqSR9iw2YvI+b6pM43GaWUKtxO5CAjhsPRs2YnRDDH7DrcDQzeRjwrdomK MIZNxkz8OHn8Di93apyNNXl3HWkf4uQE/Ze9zJjMcBonjQAsIeEPq+mMgCtFxf66Ug 4jHyvHN+W5CDHdjHLclYCa45ZxHllsOF8ctA88DY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Chris Mason , Jeff Layton , Chuck Lever Subject: [PATCH 6.18 285/552] SUNRPC: Guard svcauth_gss_release() dispatch on rq_auth_stat Date: Fri, 4 Sep 2026 06:57:22 +0200 Message-ID: <20260904045756.420479310@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260904045747.813364717@linuxfoundation.org> References: <20260904045747.813364717@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Chris Mason commit f8870b9b75afb77986bc65940a231d54068ff2b1 upstream. svcauth_gss_release() reads gc_proc and switches on gc_svc before consulting rq_auth_stat. On the SVC_DENIED path after a failed svcauth_gss_accept(), those fields may hold stale values from a prior request or uninitialized slab residue: svcauth_gss_accept() allocates gss_svc_data with non-zeroing kmalloc and clears only gsd_databody_offset and rsci per request, not clcred. Because RPC_GSS_PROC_DATA is zero, a zeroed or stale-zero gc_proc passes the existing guard and falls through into the gc_svc switch, which can dispatch to svcauth_gss_wrap_integ() or svcauth_gss_wrap_priv(). Both wrap helpers call svcauth_gss_prepare_to_wrap() before any rsci->mechctx dereference, and that helper already returns early when rq_auth_stat is not rpc_auth_ok, so the downstream NULL dereference is blocked. The dispatch itself remains structurally wrong: it reads scalars that the caller has no contract to have initialized after a failed authentication. Mirror the existing rq_auth_stat gate in svcauth_gss_prepare_to_wrap() one frame up, so svcauth_gss_release() skips the clcred dispatch entirely when authentication has not succeeded. The cleanup tail that releases rq_client, rq_gssclient, cr_group_info, and rsci still runs. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Cc: stable@vger.kernel.org Signed-off-by: Chris Mason Reviewed-by: Jeff Layton Link: https://patch.msgid.link/20260528-tier2-v1-4-d026a1415e0b@oracle.com Signed-off-by: Chuck Lever Signed-off-by: Greg Kroah-Hartman --- net/sunrpc/auth_gss/svcauth_gss.c | 2 ++ 1 file changed, 2 insertions(+) --- a/net/sunrpc/auth_gss/svcauth_gss.c +++ b/net/sunrpc/auth_gss/svcauth_gss.c @@ -1947,6 +1947,8 @@ svcauth_gss_release(struct svc_rqst *rqs if (!gsd) goto out; + if (rqstp->rq_auth_stat != rpc_auth_ok) + goto out; gc = &gsd->clcred; if (gc->gc_proc != RPC_GSS_PROC_DATA) goto out;