From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC21E378838; Fri, 4 Sep 2026 06:03:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788501781; cv=none; b=k54LTHo+T/Frv5AshUg+tSXql5zWqW9kuUbt5+p3kndhjcb/YzSlcbSVpgSntObnkTCrszZaHxg1oYpDznve0ed0X4fLw9vgwKUJ2p8f1AIH54j901xcSwWGnLa6/a1P59ZHo9dAY9CNBOusTYU0StvH7BBtFDj+6O2mcKWGh0Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788501781; c=relaxed/simple; bh=uEEvpFx4tKWXsZbYMksNZHmziJXW/Gr+U8piGGV5LoA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=J6fuWfT3jiKfYs6JPaTw870iznhTviNgIsbOszH9YaY90gpCpPWF/CdTabyb0PqMPCEvLfne7v7BMvdgtrfBWY3Kq89+3L/7PBYhMTYA9K5l6KZjPOPqZfxnhzoHNIz5WkmOeQCNsaqpWJQhi3dGURcsxYNHd09xBGpCVkt8Xd0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=SKjii7H5; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="SKjii7H5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 164AF1F00A3D; Fri, 4 Sep 2026 06:02:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788501780; bh=nr88JoR0aJilzBVppX5jdT2tRFREQayuqnwbrOu0mi0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=SKjii7H5HsEYD/k+A60debH4SJMMEAhJV+3H5qed3QMEQoJ6EEqdsoiQiFowfIT4W S5HsGQzI4h9FcDhpDTHllVUX14Y/HxnqcCJClHmKk4QMDJJMRoWW3MkcR/uzHg9qfB Da+0fG9EdeDKI51JJxSsj+JmY7i3CzoQlf/1celM= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Stanislaw Gruszka , Ping-Ke Shih , stable@kernel.org Subject: [PATCH 6.18 528/552] wifi: rtl818x: initialize eeprom_93cx6 struct to zero Date: Fri, 4 Sep 2026 07:01:25 +0200 Message-ID: <20260904045802.590478581@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260904045747.813364717@linuxfoundation.org> References: <20260904045747.813364717@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Stanislaw Gruszka commit 799b5f45cb8194ebd06c9c89e0afdad5bedd2cc5 upstream. Commit 7738a7ab9d12 ("misc: eeprom: eeprom_93cx6: Add quirk for extra read clock cycle") added extra 'quirk' field to struct eeprom_93cx6. Many existing users of eeprom_93cx6, including rtl818x drivers, allocate the structure on the stack without initializing all fields. As a result, the added quirk field has an undefined value and can randomly cause reading wrong data from the EEPROM. Fix by initializing the structures with {}. Fixes: 7738a7ab9d12 ("misc: eeprom: eeprom_93cx6: Add quirk for extra read clock cycle") Cc: stable@kernel.org # v6.13+ Signed-off-by: Stanislaw Gruszka Reviewed-by: Ping-Ke Shih Signed-off-by: Ping-Ke Shih Link: https://patch.msgid.link/20260723110640.8588-1-stf_xl@wp.pl Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/realtek/rtl818x/rtl8180/dev.c | 2 +- drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- a/drivers/net/wireless/realtek/rtl818x/rtl8180/dev.c +++ b/drivers/net/wireless/realtek/rtl818x/rtl8180/dev.c @@ -1652,7 +1652,7 @@ static void rtl8180_eeprom_register_writ static void rtl8180_eeprom_read(struct rtl8180_priv *priv) { - struct eeprom_93cx6 eeprom; + struct eeprom_93cx6 eeprom = {}; int eeprom_cck_table_adr; u16 eeprom_val; int i; --- a/drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c +++ b/drivers/net/wireless/realtek/rtl818x/rtl8187/dev.c @@ -1445,7 +1445,7 @@ static int rtl8187_probe(struct usb_inte struct usb_device *udev = interface_to_usbdev(intf); struct ieee80211_hw *dev; struct rtl8187_priv *priv; - struct eeprom_93cx6 eeprom; + struct eeprom_93cx6 eeprom = {}; struct ieee80211_channel *channel; const char *chip_name; u16 txpwr, reg;