From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 143DE351C35; Fri, 4 Sep 2026 05:29:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788499795; cv=none; b=qET6wu5YuqwU/Ubn9iBMv2TtCNjFvSlssJUYxmTXYp/v3MLPyseBtD7M8tgrZyPl0ZCm6TVsZ3OoeeITvEvp+9Pd12RTrcX3+5czqc+7zDAFPv1JfglnsWNTHN2e8X8IOl1N3uPjYHsirFWr5KA7jFeeHcnapCgPHeX8ocgjOgQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788499795; c=relaxed/simple; bh=wcmRQqtN7VDPWxrr5sajDGvhqmUW4t0hQx5rk1ElS0o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ujt3G3BoorBU9/WT8deki5Dz2jqOyGsmCwycAM/4oPpLXfWHuYue7x1awy5M9FG/ycpB9EbBVyFN9HK5BOa5hz8CWICLlkma9bYBOCg27a61yXdOi3fQ0gOEtFg5UA1F9FMSlC/G9tUao/N0h/ixQsQBbE4ZpCwXJlBZYTQPYvk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=Z5s94y50; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Z5s94y50" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3057B1F00A3D; Fri, 4 Sep 2026 05:29:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788499793; bh=qbeZIca+CgGtaCXTfsOinmZRky6WMj2jEtMI6CxemXU=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=Z5s94y50j0mjYMfiyd/Ii9iX+ZD6cL2K1xlYPGkxilPbKCMCjLbTWcj1oNG45k7sd iKPyZLzDCRH0bJfl+sjLX802iyF2A31//HCDB56KDr4caKq27S4l3CNdygipIvTRJq lXtuqU+vQEcEJ9HHFv7fYa8m7EAz/Jl4hu0PWbxE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Ma Ke , Sebastian Reichel Subject: [PATCH 7.2 500/713] power: supply: bq25890: Fix power_supply reference leak Date: Fri, 4 Sep 2026 06:57:48 +0200 Message-ID: <20260904045815.033548417@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260904045803.810145556@linuxfoundation.org> References: <20260904045803.810145556@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Ma Ke commit 863c32a83e4235eb0cbf6106f2b124e645302156 upstream. bq25890_fw_probe() acquires a reference to a secondary charger using power_supply_get_by_name(), but the reference is not released on later probe failures or on driver detach. In particular, failures after bq25890_fw_probe() returns successfully, such as a failure in bq25890_hw_init(), also leak the reference. Register a device-managed cleanup action immediately after acquiring the secondary charger. This releases the reference on all subsequent probe failures and on driver detach. Found by code review. Signed-off-by: Ma Ke Cc: stable@vger.kernel.org Fixes: d54bf877fd87 ("power: supply: bq25890: Add support for having a secondary charger IC") Link: https://patch.msgid.link/20260722044416.1623621-1-make_ruc2021@163.com Signed-off-by: Sebastian Reichel Signed-off-by: Greg Kroah-Hartman --- drivers/power/supply/bq25890_charger.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) --- a/drivers/power/supply/bq25890_charger.c +++ b/drivers/power/supply/bq25890_charger.c @@ -1389,6 +1389,14 @@ static int bq25890_fw_read_u32_props(str return 0; } +static void bq25890_release_secondary_chrg(void *data) +{ + struct bq25890_device *bq = data; + + power_supply_put(bq->secondary_chrg); + bq->secondary_chrg = NULL; +} + static int bq25890_fw_probe(struct bq25890_device *bq) { int ret; @@ -1401,6 +1409,10 @@ static int bq25890_fw_probe(struct bq258 bq->secondary_chrg = power_supply_get_by_name(str); if (!bq->secondary_chrg) return -EPROBE_DEFER; + + ret = devm_add_action_or_reset(bq->dev, bq25890_release_secondary_chrg, bq); + if (ret) + return ret; } /* Optional, left at 0 if property is not present */