From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 813E13B95FA; Fri, 4 Sep 2026 05:30:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788499843; cv=none; b=bYN2j5XSTimhQAzpcEg41Z6MsVxbDiHoe509tvKsgMxga4TH4jiTcy95wNC+sDABs10onVGwnTmRSPuAGspbjXOwl6oFlBy2nVRSUFi9bMPwgxrDJDPHlgSGeB0RcTrBdoVatFptxK0cbbF1VrV4NOZExa1dw4tGEpKA1FsPE5c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788499843; c=relaxed/simple; bh=W2MvVRiaJbuajpx0OHW2hYltUtr8BPfbpZdGJ8BtSsI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QSmnVMxRuklN8CVCjnQzhFwulauiPipllf0H3YrnQUNWKrzURE5URAr4MLBGdVB4O5sN13bs6re3Whmk3w3RGdfL2vVXjms/GpqQ5NzaH09BfXKKGZsEADsKzlJAYTUrD8SLETFCvUUB2M/seH7B5ucsypuuFDz40hN2INudcY4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=nfZDOD3X; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="nfZDOD3X" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 937251F00A3D; Fri, 4 Sep 2026 05:30:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788499842; bh=wmriFqSrQu+VOQKfd9dc4NqmrioSjnsCIWutLCIOTk4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=nfZDOD3Xgzwi3e4zeilo23fGMtc/f/E5Ac/0v/8pM37ctB2jzQTGWKDekPXu0Hwb/ hLYKj8hhJWFPWyE6miJOBQzikC3+eULo2kZyQP8j+JbLKDCCsMe2Fo6jUKEQ/QC+o4 t/fHSP7uVaFEftVNYRmnu0sjUrIouLBOLPqDscFA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Srinivas Pandruvada , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Subject: [PATCH 7.2 560/713] platform/x86: ISST: Validate parameter for core power state Date: Fri, 4 Sep 2026 06:58:48 +0200 Message-ID: <20260904045816.372678312@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260904045803.810145556@linuxfoundation.org> References: <20260904045803.810145556@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Srinivas Pandruvada commit 1700b4f804555467b7eff58dff7acc11d508b3a1 upstream. Allow only 0 or 1 for core_power enable and priority_type parameters. Fixes: 12a7d2cb811d ("platform/x86: ISST: Add SST-CP support via TPMI") Cc: stable@vger.kernel.org Signed-off-by: Srinivas Pandruvada Link: https://patch.msgid.link/20260811221514.3905817-4-srinivas.pandruvada@linux.intel.com Reviewed-by: Ilpo Järvinen Signed-off-by: Ilpo Järvinen Signed-off-by: Greg Kroah-Hartman --- drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c | 7 +++++++ 1 file changed, 7 insertions(+) --- a/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c +++ b/drivers/platform/x86/intel/speed_select_if/isst_tpmi_core.c @@ -602,6 +602,9 @@ static bool disable_dynamic_sst_features #define SST_CP_PRIORITY_TYPE_START 1 #define SST_CP_PRIORITY_TYPE_WIDTH 1 +#define SST_CP_MAX_ENABLE 1 +#define SST_CP_MAX_PRIORITY_TYPE 1 + static long isst_if_core_power_state(void __user *argp) { struct tpmi_per_power_domain_info *power_domain_info; @@ -621,6 +624,10 @@ static long isst_if_core_power_state(voi if (power_domain_info->write_blocked || !capable(CAP_SYS_ADMIN)) return -EPERM; + if (core_power.enable > SST_CP_MAX_ENABLE || + core_power.priority_type > SST_CP_MAX_PRIORITY_TYPE) + return -EINVAL; + _write_cp_info("cp_enable", core_power.enable, SST_CP_CONTROL_OFFSET, SST_CP_ENABLE_START, SST_CP_ENABLE_WIDTH, SST_MUL_FACTOR_NONE) _write_cp_info("cp_prio_type", core_power.priority_type, SST_CP_CONTROL_OFFSET,