From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C91BF414DF6; Fri, 4 Sep 2026 05:31:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788499908; cv=none; b=jQ0a/jg+zyw0EPdVs1tceAFr6fwDXE/xPKTWkpKxZGzgw9YE1+XIiiDcGSqSyY8SzrVywa8ao70LWtNhnXTGO/XF09ah8Nw7bwOyvO0I2xlJUGK3iWtppF/o1oMNa9bGDTQ5rGEZqxw8z7jdUUiojQNoPRs75rX/Mvg1jRiX/dg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788499908; c=relaxed/simple; bh=DWHrUCxfrJ5/eQCa/vwdPlZQ9fgnVo2wN8Hai1B5YnQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=aaJ9/iIDmaQLXtKFR8t0CrmyG5QhH/806svvqUwS9XRjR3zPi0YNkdb4z6+0pC3e+VaZwvbKaZc+jYif7EoqQzzRoxQHpt9vM40dznXyWhXKAf53KazL1faDGfDFsVV66Dj/sSiiCIiE8toU+2eOVoQ8yWWbFPd6/AcR9XMHKzo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=JsPkBTnK; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="JsPkBTnK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2304D1F00A3D; Fri, 4 Sep 2026 05:31:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788499907; bh=mvcQsl2fAYWLy5PDNufPIYmWZER/FZWHKGD+3R+FEPQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=JsPkBTnKhxacHCbG/fVBSKAR98/1S4NNGGbPOqBgv/yLclMWHT15I/fNAhNtVjYUa MX8Okep/r0spM8tRuRc4EoV99gh3iq5K/2RbDjXN7Exam/f4hRMooeBGAOEb0bxRqU 1MR9OHCtcA1OQiNNlP6fJuS+dgbdHXnwq332O4GU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Muhammad Bilal , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Subject: [PATCH 7.2 581/713] platform/x86: hp-bioscfg: fix new_password_store() overwriting current_password Date: Fri, 4 Sep 2026 06:59:09 +0200 Message-ID: <20260904045816.841801993@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260904045803.810145556@linuxfoundation.org> References: <20260904045803.810145556@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Muhammad Bilal commit 2ea12a467a9cb12170417b30784fe26a243a75fe upstream. current_password_store() and new_password_store() both call store_password_instance() with is_current = true: static ssize_t new_password_store(...) { return store_password_instance(kobj, buf, count, true); } so a write to new_password is routed to current_password instead, and the new_password field is never written by either sysfs entry point. Fix by passing false from new_password_store(), matching what the is_current parameter is meant to select. Fixes: 8646a3b5ee3a ("platform/x86: hp-bioscfg: passwdobj-attributes") Cc: stable@vger.kernel.org Signed-off-by: Muhammad Bilal Link: https://patch.msgid.link/20260812111829.172273-8-meatuni001@gmail.com Reviewed-by: Ilpo Järvinen Signed-off-by: Ilpo Järvinen Signed-off-by: Greg Kroah-Hartman --- drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c +++ b/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c @@ -123,7 +123,7 @@ static ssize_t new_password_store(struct struct kobj_attribute *attr, const char *buf, size_t count) { - return store_password_instance(kobj, buf, count, true); + return store_password_instance(kobj, buf, count, false); } static struct kobj_attribute password_new_password = __ATTR_WO(new_password);