From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1297B415B8F; Fri, 4 Sep 2026 05:33:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788500031; cv=none; b=cHqLZsJ9sY7/9yYnoD4iXHinEMNnXX/pWpBtEngfhe4AsRyjutKgNnaRNfZj6vNJw47GzBriqCerBva3gHdV8i6nSqD/RUDRxZP3sZ0tEG9ufO2ptM2otYa4XxBgcqD2/oIS6+H1EnXhq2zOBDzsklLRl5+iNt5pXc1p01ygcCI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788500031; c=relaxed/simple; bh=RiU2cNq6Ur2VyJsspJ+XSqz9MRMRQgpjOdOFZKhYr+I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dk7xrCrVgzgM2C+03kc+OkrjShrw21uHTgsn4EtICDpkPBqmcbZ0V1h0VWrYI271T2afZi93mlxWi+ulLTAtIk1AS3A2F6Aoy6+zfyuFwmrdAVPawbea5pU4USitEu/K1HpVUPG8djIx1uhME8GyqQLPH4SrtVdapCQipHzzpvQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=bS8e46+i; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="bS8e46+i" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6488D1F00A3D; Fri, 4 Sep 2026 05:33:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788500029; bh=2m8qQYd1Pm/ANK69j/S3IS14gH0PJ+eh1T1YziESc40=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=bS8e46+iUTKh7QLhHzpBFzgGG+5D6sRazHMu9Bz2EP1fqRZ0Txg7hWLUyAjSLTH+S Ec0+riPNbY3AiXCfbU2b3ZyzYLGrnvqeGUSPLLtyIHpqNUBfw4R7AJpiIlgi2svEjO lhc3L6hxtG57YC3tdrCHL66+mbZNiVgOxgd0KJd8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Mahanta Jambigi , Hidayath Khan , Simon Horman , Jakub Kicinski Subject: [PATCH 7.2 625/713] net/smc: stop killed, freed and out_of_sync sharing a byte Date: Fri, 4 Sep 2026 06:59:53 +0200 Message-ID: <20260904045817.837425591@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260904045803.810145556@linuxfoundation.org> References: <20260904045803.810145556@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Hidayath Khan commit db51a8658c11a82432b64999519a269c3aabb447 upstream. The three connection state flags are single-bit bitfields, so they occupy one byte of struct smc_connection and every store to one is a read-modify-write of the other two: u8 killed : 1; u8 freed : 1; u8 out_of_sync : 1; They are not written under a common lock. smc_cdc_msg_validate() sets out_of_sync from the receive tasklet, while smc_conn_kill() sets killed from process context under lock_sock(), and the receive path does not defer to the backlog when the socket is owned -- smc_cdc_msg_recv() takes only bh_lock_sock(). Give each flag its own byte so a store no longer touches its neighbours. All readers test them as booleans and are unchanged. struct smc_connection grows by two bytes. Fixes: b286a0651e44 ("net/smc: handle incoming CDC validation message") Cc: stable@vger.kernel.org Reviewed-by: Mahanta Jambigi Signed-off-by: Hidayath Khan Reviewed-by: Simon Horman Link: https://patch.msgid.link/20260820074642.966856-2-hidayath@linux.ibm.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- net/smc/smc.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- a/net/smc/smc.h +++ b/net/smc/smc.h @@ -277,9 +277,9 @@ struct smc_connection { * 0 for SMC-R, 32 for SMC-D */ u64 peer_token; /* SMC-D token of peer */ - u8 killed : 1; /* abnormal termination */ - u8 freed : 1; /* normal termination */ - u8 out_of_sync : 1; /* out of sync with peer */ + u8 killed; /* abnormal termination */ + u8 freed; /* normal termination */ + u8 out_of_sync; /* out of sync with peer */ }; struct smc_sock { /* smc sock container */