From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04E523EC6AE; Fri, 4 Sep 2026 05:37:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788500260; cv=none; b=NDhjpdX8h6R4vvgrHp+3nz+PwYif3HT/MbS/pYpLJjMNh3gJNVAzKpyG8RHTnmkNlzaeGY8WdMoL3we5IPLcjXaCUArdtYXt8kdf2Y1weDfIRZV6fs9pAIzfOuSu1GlDQc2xmQHi6HiBw0JNRfbZeWIuCo3vhadiP85pBSmx3gs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788500260; c=relaxed/simple; bh=+VNEYL0xuXQGZ1njjC10TiwIrmwYKsp0K+tIUh+2AoE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UVr7P8NSBYex8wDO0qFxCYl3mpbfgThTiNApIG8GggsXvDD9PPUzJlTtS3MXN4w4a3rdVa3aYQqgOb9l1Rz7vj/Yc28YHaikjoJF3rLnlcU+Hl36wh2jt7JuzYhMp+Nd8orVCnT/sGBC/iz7pcvumIheESLgtkNU87NF1XIHnDQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=H48095AB; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="H48095AB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 608E41F00A3D; Fri, 4 Sep 2026 05:37:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788500258; bh=/B7YCAQx5NJZr7CLWLgUv4tW5RptWji3+iE72weFQTo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=H48095ABBrTQAg1ROrqixfHo6xZwd9FJW9xIP0A4SCcYwuBrBHHl+yEeGoTnc7B55 9dsaFXEKqlgPw3PpoyWNchNEsKyFl+k5h+H9sbD2OXxfOPkDM3WJqk23ihmIum/DnU NyU1ouK9if59R1BV1R5BV/0fYsaaIT3bdrxsvHRA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Bradley Morgan , Oleg Deomi , Andrew Morton , Balbir Singh Subject: [PATCH 7.2 707/713] taskstats: fix cpumask parsing cutting off the last character Date: Fri, 4 Sep 2026 07:01:15 +0200 Message-ID: <20260904045819.697030752@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260904045803.810145556@linuxfoundation.org> References: <20260904045803.810145556@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Bradley Morgan commit 1f58a5335cdd14b3fb5f2a5d3763dee1f5cba1d3 upstream. parse() hands nla_strscpy() len as dstsize, and nla_strscpy() copies at most dstsize - 1 bytes. When the attr payload comes in without a trailing NUL, srclen == len >= dstsize and the last character of the cpumask string gets cut off. Register "0-15" and you are silently listening on "0-1", exit data for the rest never shows up. The bug only bites when the sender doesn't NUL terminate the payload; senders that include the NUL were always fine (srclen gets decremented for the trailing NUL, so srclen < dstsize). Thats probably why this survived 20 years. And the policy is NLA_STRING, not NLA_NUL_STRING, so a payload without the trailing NUL is legit input here. Skip the kmalloc/nla_strscpy dance entirely and use nla_strdup(), which already allocates srclen + 1 and terminates. The nla_len() bounds checks stay as they were. Link: https://lore.kernel.org/EC49FE41-7F5F-41E0-A07A-ABEB8ECA514D@grrlz.net Fixes: f9fd8914c1ac ("[PATCH] per-task delay accounting taskstats interface: control exit data through cpumasks") Signed-off-by: Bradley Morgan Reported-by: Oleg Deomi Closes: https://lore.kernel.org/CAByWkfZ6b1=3H9pwkz-dDQOs9cZaF-HYQ6b9Yb0=Hq2r1Vv_Pw@mail.gmail.com Reviewed-by: Andrew Morton Cc: Balbir Singh Cc: Signed-off-by: Andrew Morton Signed-off-by: Greg Kroah-Hartman --- kernel/taskstats.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/kernel/taskstats.c +++ b/kernel/taskstats.c @@ -368,10 +368,9 @@ static int parse(struct nlattr *na, stru return -E2BIG; if (len < 1) return -EINVAL; - data = kmalloc(len, GFP_KERNEL); + data = nla_strdup(na, GFP_KERNEL); if (!data) return -ENOMEM; - nla_strscpy(data, na, len); ret = cpulist_parse(data, mask); kfree(data); return ret;