From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5268B5678EF; Wed, 9 Sep 2026 14:14:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788963277; cv=none; b=H+wpDtbv6zciqYuHOzjmOmkXQodWawIUjhbhuSnu8R75JxdKqnvWltJXAiGTFz7PB15jxQaKFG5qRkfiry3V5ec/6qfutC7e8ajPl/okdlgylyX8Jh4kwP00yG6bOiI2a45MxKuTfPlv0fZiOpf7CsCPun2i26svYgPnm01XjMY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788963277; c=relaxed/simple; bh=O/BL239W34whG7DsZEA11M6/XHY/bCAMsLMo8rlD6sE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=o4yaNRuOuB/WsCNwtD1NS1CDmU4/mt1Hye/DqgYBHPouINBOQeZqqbdf2HAlQHScW1gONTUiO2kQxKJIJwhUnF7CjHQyICuEz/rbX4utOxHbEpy+Zswu7vNe3sTPe5+dhnLlVOQwuZ6PCJSMnM01oxfaZi13YHJG5fX9doKIZ0E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ef470SHb; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ef470SHb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87B5A1F00A3A; Wed, 9 Sep 2026 14:14:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788963276; bh=K+VV4DiI8N/9yxcyv9+MZaXCb6OzAmEPTl+YwuYgTic=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ef470SHbRfSo3nOqzK/TVO06xR47ydGETE80nQRZslb29FFSyKeTJ+L+I9BP2Yvk7 wLBWYrZtd0jRdI42UHkkBwY8cLu2u2piqjIT0zOYHUHtqKB+bE/SUZpFiTieV2xNq0 cQjn1VnwLpix3GKl91bxSD4A3CGfM4hs23mGDyOI= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, stable , Fan Wu , Konrad Dybcio , Bryan ODonoghue , Heikki Krogerus Subject: [PATCH 6.18 023/583] usb: typec: qcom-pmic: cancel reset_work on stop Date: Wed, 9 Sep 2026 15:35:08 +0200 Message-ID: <20260909134238.630603492@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260909134237.773280130@linuxfoundation.org> References: <20260909134237.773280130@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Fan Wu commit 7b0df6efd143f8085bdb68778a013a46f1349913 upstream. pdphy_stop() disables IRQs but leaves reset_work pending. If the IRQ handler schedules it just before disable_irq(), the work runs after remove() frees the struct via devm. Call cancel_work_sync() after disabling IRQs to close the window. This issue was found by an in-house static analysis tool. Fixes: a4422ff22142 ("usb: typec: qcom: Add Qualcomm PMIC Type-C driver") Cc: stable Assisted-by: Codex:gpt-5.6 Signed-off-by: Fan Wu Reviewed-by: Konrad Dybcio Reviewed-by: Bryan O'Donoghue Reviewed-by: Heikki Krogerus Link: https://patch.msgid.link/20260819161448.76597-1-fanwu01@zju.edu.cn Signed-off-by: Greg Kroah-Hartman --- drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c +++ b/drivers/usb/typec/tcpm/qcom/qcom_pmic_typec_pdphy.c @@ -544,6 +544,8 @@ static void qcom_pmic_typec_pdphy_stop(s for (i = 0; i < pmic_typec_pdphy->nr_irqs; i++) disable_irq(pmic_typec_pdphy->irq_data[i].irq); + cancel_work_sync(&pmic_typec_pdphy->reset_work); + qcom_pmic_typec_pdphy_reset_on(pmic_typec_pdphy); regulator_disable(pmic_typec_pdphy->vdd_pdphy);