From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF8DB2D9780; Wed, 9 Sep 2026 14:03:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788962621; cv=none; b=tOqRCvc9cz8aYF7yzHkCNZZT8I1M3+89+8kFMDWC7NXu/QpJAE8BYcibDm1WQXVsDfD20AqcjmwG7BHMIk3yK8wNDrvssy/hN0TO8/PGPqRjNgT44BblsnSCl7TXkViSa156BEVKqSY41KpH6PHp9FXlqIjrsrBN/ryqkwSYvcc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788962621; c=relaxed/simple; bh=cNC4txSLL3yDPSRKOW15/EKKqk6KJxJHPjpRI1FWus4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=icHSTC2g3DWrJwo774nD/k5mfGlTeaAzUgIMrevTAAoYmUTmUoxsRVlQeoaS3yUDnOAgZyrhQiS45Xw06Jb6ktJCFXa4KrWaNkWT+QDyvXp7Ew1/razVoUi34ImXGcz5wUkgymvLwxuyTdpLZB8d6nulYjZdelvUXGQU3a3YbBU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=F2IVRq7b; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="F2IVRq7b" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF6741F00A3A; Wed, 9 Sep 2026 14:03:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788962619; bh=gMzhzYRBr3xTsyEkdAsetYB/CAolskClU9c5ndXxmhE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=F2IVRq7bm0m2k302CCnWs2gHmZn2c0uIm8fWOMdn797IH4P0ihdiSaydVbUYKMrn0 z31yvMOBwqQdQkNo1bgGkwWFeUhO9r8Cs5wXyhV/VpXMWhifZdFyUyrCsAWmRBXNMH MYAk4CQK4SGs+sALyrIZEG3aXh7lbtSL8XzdywcE= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Dawei Feng , Jernej Skrabec , Dan Carpenter , Nicolas Dufresne , Hans Verkuil Subject: [PATCH 7.2 354/556] media: cedrus: fix memory leak in cedrus_init_ctrls() Date: Wed, 9 Sep 2026 15:40:34 +0200 Message-ID: <20260909134243.119537730@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260909134230.441546314@linuxfoundation.org> References: <20260909134230.441546314@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 7.2-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dawei Feng commit 9df2fbe563194da1967a5db083442186c1323efe upstream. In cedrus_init_ctrls(), the V4L2 control handler is initialized before allocating memory for ctx->ctrls. If this allocation fails, the function returns -ENOMEM without freeing the previously allocated handler resources, leading to a memory leak. Fix this by calling v4l2_ctrl_handler_free() on the ctx->ctrls allocation failure path. The bug was first flagged by an experimental analysis tool we are developing for kernel memory-management bugs while analyzing v6.13-rc1. The tool is still under development and is not yet publicly available. Manual inspection confirms that the bug is still present in v7.1.1. An x86_64 allyesconfig build showed no new warnings. As we do not have an Allwinner SoC or board with a Cedrus VPU available to test with, no runtime testing was able to be performed. Fixes: 50e761516f2b ("media: platform: Add Cedrus VPU decoder driver") Cc: stable@vger.kernel.org Signed-off-by: Dawei Feng Acked-by: Jernej Skrabec Reviewed-by: Dan Carpenter Signed-off-by: Nicolas Dufresne Signed-off-by: Hans Verkuil Signed-off-by: Greg Kroah-Hartman --- drivers/staging/media/sunxi/cedrus/cedrus.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/staging/media/sunxi/cedrus/cedrus.c +++ b/drivers/staging/media/sunxi/cedrus/cedrus.c @@ -285,8 +285,10 @@ static int cedrus_init_ctrls(struct cedr ctrl_size = sizeof(ctrl) * CEDRUS_CONTROLS_COUNT + 1; ctx->ctrls = kzalloc(ctrl_size, GFP_KERNEL); - if (!ctx->ctrls) + if (!ctx->ctrls) { + v4l2_ctrl_handler_free(hdl); return -ENOMEM; + } j = 0; for (i = 0; i < CEDRUS_CONTROLS_COUNT; i++) {