From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F37BF5650F4; Wed, 9 Sep 2026 14:23:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788963784; cv=none; b=VgbE2PXXCvl4Nw0vWcIgxliChE/PRY0TUSEU0fFPIWUymNv1ktiNIVCFd5P91T1DUBSv62JJ/Y8UBpu1R10yKdzeBIPMRPGTP+piA/knARFruKwFucEfwuUzf2JQ6Zsz361bAwJGAhItU4P4j3KOLyVNXKxrNzrARdTZvN1Ri/M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788963784; c=relaxed/simple; bh=8/rPcsbSRvnjp6TLNe1GZzVmjekIwXC2JX38nyRtJX8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XDAUMR5eOlqVyRDyPNjYphqQLmWe5bkZNdK+bnBL5j4J+KPoBPSHb4ecN9Bi/JVhhhXaR9Dq624xo5wccSB3fzbLLu4YM9v+i3w8njmuYx3zXVIE7arUntkGqH4SAd8RGTQQJbRqvJcBOy0CYWvWLrpyzVULE2ePv3WZRYjrh/Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=B7skBllM; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="B7skBllM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9DDC1F00A3A; Wed, 9 Sep 2026 14:23:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788963782; bh=LllvlKxcGHkRcut+UwoSdHN2ENeL5ZYAqQFAf76rxVk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=B7skBllM6+MwFJ1aGbQU2asvkW9q9QNmduHt5j5dNNF10qj2aXtPPLYvcrztYNhOc y2OsIEjm1Oh/SV2cUl+TSDXKgCt3OGcnPVeS2q8kVVxrZrygGT/1Svp5KVzuda78oj TvCLE9T5e/Aw9f0swJ8xJTwEA88Yw1UtK0kI90UY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Peter Ujfalusi , Mark Brown Subject: [PATCH 6.18 197/583] ASoC: tegra210_mixer: sort the register default table Date: Wed, 9 Sep 2026 15:38:02 +0200 Message-ID: <20260909134244.983230019@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260909134237.773280130@linuxfoundation.org> References: <20260909134237.773280130@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Peter Ujfalusi commit f70bc276fc7f712ff5c8e995d5050558a3198df2 upstream. reg_defaults must be sorted by ascending register address, as regcache_lookup_reg() locates entries in it with bsearch(). See commit fd80df352ba1 ("regcache: Add support for sorting defaults arrays"). TEGRA210_MIXER_ENABLE (0x400) is the last entry of the table, after TEGRA210_MIXER_PEAKM_RAM_CTRL (0x434), which makes it unreachable. regcache_reg_needs_sync() then cannot compare it against its default and reports that a sync is needed, so it is written to the device on every regcache_sync() even when it was never touched. Sort the table by register address. Fixes: 05bb3d5ec64a ("ASoC: tegra: Add Tegra210 based Mixer driver") Cc: stable@vger.kernel.org Signed-off-by: Peter Ujfalusi Link: https://patch.msgid.link/20260805122748.13090-4-peter.ujfalusi@linux.intel.com Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- sound/soc/tegra/tegra210_mixer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/sound/soc/tegra/tegra210_mixer.c +++ b/sound/soc/tegra/tegra210_mixer.c @@ -57,10 +57,10 @@ static const struct reg_default tegra210 MIXER_TX_REG_DEFAULTS(3), MIXER_TX_REG_DEFAULTS(4), + { TEGRA210_MIXER_ENABLE, 0x1 }, { TEGRA210_MIXER_CG, 0x00000001}, { TEGRA210_MIXER_GAIN_CFG_RAM_CTRL, 0x00004000}, { TEGRA210_MIXER_PEAKM_RAM_CTRL, 0x00004000}, - { TEGRA210_MIXER_ENABLE, 0x1 }, }; /* Default gain parameters */