From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA898568FDA; Wed, 9 Sep 2026 14:28:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788964106; cv=none; b=N0lMQ65O2Pb4CttBvHNgXKQUdCFiHaLssV7BK0hrhVbMiwp1wOIOFWXL2McoNy47NEIXdJsks9F4trTdQL2nSeGWRgqQOV4FF6jODmOgRX4WzlmokkHZ8OYPTwjAlS1IU7pfq1cTm1XicsZ9dROFftGdBOhBQXWgRTNEQ2nK+is= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788964106; c=relaxed/simple; bh=TYb4ltGhh0YdURWFgwqbNFdDED+BtiVNPbH5z9Ucqzg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=T4PK7EhZFSe2jhMWq++f0KQ57oTJmDJVaxgP4Oyld3wes4UE1VeGhV9Ymz3ZHkmewtwJOQ8qhwMjuEAa/EmdBpHm/XYMtwRaWsRBaaJ1qvqqYEFgAnZJ6v92A+kGMD4sHm/YBGOR8+GEurBwfHIgERlsIrH+XoLfRgGApICLEZw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ZoYSBaua; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ZoYSBaua" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 004361F00A3A; Wed, 9 Sep 2026 14:28:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788964104; bh=EYG96gfRxJCQUS5kE43o7uoVdi/NhiEbUOKG9NVGeI4=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ZoYSBaua/Oyl1uW2YsWo3gYGE7bzgPS9DGALq+7F/1IxhnLQq9dQbM1xCPj5upqr2 tcx7Yd/dFWLw0/IjD0wuZKXBIl17dre9+3juslpbomqZZBsPH8SPGauAwZvCslKhM+ OoT357Q5PtZj9NU/AHcZ3r2mTgdZ84BAWvNYYRKo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, HyeongJun An , Hans Verkuil Subject: [PATCH 6.18 307/583] media: s2255: bound JPEG frame size before copying into the buffer Date: Wed, 9 Sep 2026 15:39:52 +0200 Message-ID: <20260909134248.645216825@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260909134237.773280130@linuxfoundation.org> References: <20260909134237.773280130@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: HyeongJun An commit e504cc888f42999dd76b6a43788c422610f2aad2 upstream. s2255_fillbuff() memcpy()s vc->jpg_size bytes of a captured JPEG/MJPEG frame into the vb2 plane. vc->jpg_size is taken verbatim from the S2255_MARKER_FRAME header the device sends (pdword[4] in save_frame()) and, unlike the frame payload length just above it, is never bounded: payload = le32_to_cpu(pdword[3]); if (payload > vc->req_image_size) /* payload is checked ... */ return -EINVAL; vc->pkt_size = payload; vc->jpg_size = le32_to_cpu(pdword[4]); /* ... jpg_size is not */ A malicious or malfunctioning device can therefore report a jpg_size larger than the destination vb2 plane, and the memcpy() writes past it. jpg_size is a signed int, so a value with the top bit set also turns into a huge length. Reject a frame whose jpg_size is negative or exceeds the plane size before copying it. Fixes: 38f993ad8b1f ("V4L/DVB (8125): This driver adds support for the Sensoray 2255 devices.") Cc: stable@vger.kernel.org Assisted-by: Claude:claude-opus-4-8 Signed-off-by: HyeongJun An Signed-off-by: Hans Verkuil Signed-off-by: Greg Kroah-Hartman --- drivers/media/usb/s2255/s2255drv.c | 6 ++++++ 1 file changed, 6 insertions(+) --- a/drivers/media/usb/s2255/s2255drv.c +++ b/drivers/media/usb/s2255/s2255drv.c @@ -617,6 +617,12 @@ static void s2255_fillbuff(struct s2255_ break; case V4L2_PIX_FMT_JPEG: case V4L2_PIX_FMT_MJPEG: + if (jpgsize < 0 || + jpgsize > vb2_plane_size(&buf->vb.vb2_buf, 0)) { + dprintk(dev, 1, "bad JPEG frame size %d\n", + jpgsize); + break; + } vb2_set_plane_payload(&buf->vb.vb2_buf, 0, jpgsize); memcpy(vbuf, tmpbuf, jpgsize); break;