From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C67E58038E; Wed, 9 Sep 2026 14:30:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788964248; cv=none; b=OSaKfgMn6FpMsRyaBU7Ty8ndpzJR3FrAdmjpFL80cOhzHaqmn63qQBPGN6gQW5RAYqypYltsUe2iS6ZSv8Ed+oDzIlf1f0FymGODatUOKj/V9WEeILXDbpxCMY3iDLlr9HIZ/sVq0YtO9YF6x3xTr+6uxCfh492AEZhkxKYiF9Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788964248; c=relaxed/simple; bh=3A3HsHValgbZk2oULMH4tDa6VKvbgqbQ/whRZ/NmdU0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=P8jomRQSKcUzpZA8lJQJkEYV0C5RtHllvp12x0RYfsClU1g2gJ8O/ClZ2aTh18CvGIa6BrOXUI85nz2nJq8zTgIBcluUgf3BeRwSl7ZuzVnOLDVUcRnbdMrtSHk3sdij7HQu6Vrvgp4h9zvCm7StV8ELKuK48C/FpCjdyF+5Mhw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=1wpPG1WU; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="1wpPG1WU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5C331F00A3A; Wed, 9 Sep 2026 14:30:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1788964246; bh=NSetlg1oSVOJq12uWYigNV+FzIuu1M/M3GS2XS9jMuo=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=1wpPG1WUWWAUuksv954UJcgaMxwN9N4Uw0wHjbkdBFbP37hUdA3JZWZLad51RvABq V+RfDDe9Lm1s/HSLG49aOQtSuIoCA9WXuAG2sW+WsdnWBf7XSP7kczDaIXz6NBdbMw 6czXhvqKVkhgj54h8m/fde4kSkekSETdP7yI95T8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Joanne Chang , Chao Yu , Jaegeuk Kim Subject: [PATCH 6.18 355/583] f2fs: dirty directory inodes on mtime/ctime update Date: Wed, 9 Sep 2026 15:40:40 +0200 Message-ID: <20260909134250.301232210@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260909134237.773280130@linuxfoundation.org> References: <20260909134237.773280130@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 6.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Joanne Chang commit 9ec09d5f4b317a417c8655c14056f70cbe71eb6c upstream. Xfstests generic/547 sometimes fail with mismatched directory metadata before and after a power failure. This happens because when a directory entry is added, renamed, or deleted, its mtime and ctime are updated and the inode is marked dirty via f2fs_mark_inode_dirty_sync(dir, sync=false). The sync=false flag means the dirty inode is not added to the global DIRTY_META list. Therefore, subsequent checkpoints skip flushing these updated directory blocks, causing directory timestamps to revert to stale values after a sudden power failure. Address this by changing the dirtying parameter to sync=true during directory entry mutations and renames. This forces F2FS to immediately queue the updated directory blocks on the global DIRTY_META list, ensuring timestamps are committed to checkpoints. Fixes: 7c45729a4d6d ("f2fs: keep dirty inodes selectively for checkpoint") Cc: stable@vger.kernel.org Signed-off-by: Joanne Chang Reviewed-by: Chao Yu Signed-off-by: Jaegeuk Kim Signed-off-by: Greg Kroah-Hartman --- fs/f2fs/dir.c | 6 +++--- fs/f2fs/inline.c | 2 +- fs/f2fs/namei.c | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) --- a/fs/f2fs/dir.c +++ b/fs/f2fs/dir.c @@ -453,7 +453,7 @@ void f2fs_set_link(struct inode *dir, st folio_mark_dirty(folio); inode_set_mtime_to_ts(dir, inode_set_ctime_current(dir)); - f2fs_mark_inode_dirty_sync(dir, false); + f2fs_mark_inode_dirty_sync(dir, true); f2fs_folio_put(folio, true); } @@ -608,7 +608,7 @@ void f2fs_update_parent_metadata(struct clear_inode_flag(inode, FI_NEW_INODE); } inode_set_mtime_to_ts(dir, inode_set_ctime_current(dir)); - f2fs_mark_inode_dirty_sync(dir, false); + f2fs_mark_inode_dirty_sync(dir, true); if (F2FS_I(dir)->i_current_depth != current_depth) f2fs_i_depth_write(dir, current_depth); @@ -920,7 +920,7 @@ void f2fs_delete_entry(struct f2fs_dir_e f2fs_folio_put(folio, true); inode_set_mtime_to_ts(dir, inode_set_ctime_current(dir)); - f2fs_mark_inode_dirty_sync(dir, false); + f2fs_mark_inode_dirty_sync(dir, true); if (inode) f2fs_drop_nlink(dir, inode); --- a/fs/f2fs/inline.c +++ b/fs/f2fs/inline.c @@ -720,7 +720,7 @@ void f2fs_delete_inline_entry(struct f2f f2fs_folio_put(folio, true); inode_set_mtime_to_ts(dir, inode_set_ctime_current(dir)); - f2fs_mark_inode_dirty_sync(dir, false); + f2fs_mark_inode_dirty_sync(dir, true); if (inode) f2fs_drop_nlink(dir, inode); --- a/fs/f2fs/namei.c +++ b/fs/f2fs/namei.c @@ -1047,7 +1047,7 @@ static int f2fs_rename(struct mnt_idmap f2fs_up_write(&F2FS_I(old_inode)->i_sem); inode_set_ctime_current(old_inode); - f2fs_mark_inode_dirty_sync(old_inode, false); + f2fs_mark_inode_dirty_sync(old_inode, true); f2fs_delete_entry(old_entry, old_folio, old_dir, NULL); old_folio = NULL; @@ -1216,7 +1216,7 @@ static int f2fs_cross_rename(struct inod f2fs_i_links_write(old_dir, old_nlink > 0); f2fs_up_write(&F2FS_I(old_dir)->i_sem); } - f2fs_mark_inode_dirty_sync(old_dir, false); + f2fs_mark_inode_dirty_sync(old_dir, true); /* update directory entry info of new dir inode */ f2fs_set_link(new_dir, new_entry, new_folio, old_inode); @@ -1235,7 +1235,7 @@ static int f2fs_cross_rename(struct inod f2fs_i_links_write(new_dir, new_nlink > 0); f2fs_up_write(&F2FS_I(new_dir)->i_sem); } - f2fs_mark_inode_dirty_sync(new_dir, false); + f2fs_mark_inode_dirty_sync(new_dir, true); if (F2FS_OPTION(sbi).fsync_mode == FSYNC_MODE_STRICT) { f2fs_add_ino_entry(sbi, old_dir->i_ino, TRANS_DIR_INO);