From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3F9437E2F3; Sat, 12 Sep 2026 19:20:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789240826; cv=none; b=tomtUebe3gsju8cBITxZdtFYBwoKkoaGER9bX/gMIewxofYitqi1nNTQI/nz9k3kiRbn/Bflssn8vybmCpMbeK2bKnFx6guJrQX+WNoIJbyl+le+iNr1BezyiCGDl91+7tk7vP0CARQTGABm1sNwXTruA5UfnKnfB/vrfGDirBY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789240826; c=relaxed/simple; bh=VMHul17c9lMpk/aWOmYxl8F0l6PE4PwfSorQBw3dvgE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=BTrgWO9nGn21UHDZOFfiKaBjFbC96M76s3bKNOhhDmbPG9bgjbjtVhcTnb6M6a62mPHGvmRfxlPUtbI0WBM+NGugkebGiuXTwODXXlSu5NrU8T1Asy9ZCd5nGEaAR7ZgnVvWMmcXJ8qEpYzrImflOIFy5XbBHdJqozwX5ARwe9s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=hKpLtdGy; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="hKpLtdGy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83C611F000FF; Sat, 12 Sep 2026 19:20:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789240825; bh=SiHCz0qf4xFrrC1Mn7ia8ECS631cLMR3lf7yqc8VNPc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=hKpLtdGy2HD70AbUdOZBVoFUxHD12fV4pFZgQyT/oeplRSRTIS6VNUE3SIsyZpNPF qYhPKfbK8/lO7AkIiVd0BQT1KRFM3Kgo0QpHGeJqB5kxmLJn/AAEGyvLnmPzSWq5B6 04roGM8rnVUUxIYUYyBzHhneokuMq8ORrMqfAOuY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, =?UTF-8?q?J=C3=A9r=C3=A9my=20Jean?= , Thomas Gleixner Subject: [PATCH 5.10 004/798] timers/itimer: Zero-init old itimerval before copy to userspace Date: Sat, 12 Sep 2026 08:53:52 +0200 Message-ID: <20260912065517.059421919@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065516.948645775@linuxfoundation.org> References: <20260912065516.948645775@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jérémy Jean commit 18c7d85864e554adc8fad1e8d2e9d2cb6c3911c8 upstream. On native sparc64, struct __kernel_old_timeval contains a four-byte hole after tv_usec because tv_sec is 64-bit while __kernel_suseconds_t is 32-bit. put_itimerval() fills only the named fields in a stack-allocated __kernel_old_itimerval and copies the entire object to userspace, so getitimer() can expose the two padding holes. Zero-initialize the aggregate before assigning the fields so implicit padding is deterministic before it crosses the user/kernel boundary. Signed-off-by: Jérémy Jean Signed-off-by: Thomas Gleixner Assisted-by: Codex:gpt-5 Cc: stable@vger.kernel.org Link: https://patch.msgid.link/20260809190428.1523014-1-Jeremy.Jean@oss.cyber.gouv.fr Signed-off-by: Greg Kroah-Hartman --- kernel/time/itimer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/kernel/time/itimer.c +++ b/kernel/time/itimer.c @@ -100,7 +100,7 @@ static int do_getitimer(int which, struc static int put_itimerval(struct __kernel_old_itimerval __user *o, const struct itimerspec64 *i) { - struct __kernel_old_itimerval v; + struct __kernel_old_itimerval v = {}; v.it_interval.tv_sec = i->it_interval.tv_sec; v.it_interval.tv_usec = i->it_interval.tv_nsec / NSEC_PER_USEC;