From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EF133438BE; Sat, 12 Sep 2026 19:22:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789240965; cv=none; b=dINCYL5tLQ6aYw0REEi6Byl0NVQp3ASOX5aaBxWIsKKvZ1nATxnbqwbU7HK8TcSedL+Gayorv3gGaQQ2wbrtEtJKpZhx4W8SHra3tR3QZzC0td2hLOM4ftBnKOLDKjJn8uI8BYjJuP3vsx36gZLY7arAfiYR3s/6ZbhvPZiLbMY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789240965; c=relaxed/simple; bh=a1esOX9+o6dLQAaK29r6CAwMnVRAcnxkpXIxbmREipA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Ml+tjsc1HmGNYUAcZTTipZYr9vBOCaf6aY2+4L/bimCKiYM8ncnou26gejmwhJYcJ8UtfAyAAQQncHg4NF70XUnmgzeMQg0402xAnpDybtaERCo7HrBqiV8RYzaXiYNHAn3wZxz8pTj0nJC1ML6w3TSJjZpq2oVC6RTh3NWmB/w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=DnYu2jNI; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="DnYu2jNI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE07B1F000FF; Sat, 12 Sep 2026 19:22:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789240964; bh=NHcG5JUWztvVICsHP9A60SuRKYcfFDc+mIRYeB4UWMk=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=DnYu2jNI1d90xeMdpwyhS5kM19CLM+94OUwiBv5E1cgX09oVpmIkH0+D9Z41ZW14k B4LziG2ptwBBcT4hLuJM3zr4GBFkeWlRd99g1VKHak8+kh9aaSuLrz5PBcFJPWUmg4 MjmmqCXtSiTaKCgK8kLqq3Q8rCo/MVW73xv2raxo= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, James Kim , Dan Carpenter , Alexandre Bounine , Matt Porter , Andrew Morton Subject: [PATCH 5.10 012/798] rapidio: mport_cdev: fix use-after-free in dma_req_free() Date: Sat, 12 Sep 2026 08:54:00 +0200 Message-ID: <20260912065517.239893345@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065516.948645775@linuxfoundation.org> References: <20260912065516.948645775@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: James Kim commit 5cbef379a94b161726c5f504598bf4791d45cedc upstream. dma_req_free() acquires buf_mutex through req->map, drops the mapping reference with kref_put(), and then dereferences req->map again to unlock the mutex. If kref_put() drops the last reference, mport_release_mapping() frees the mapping, and the subsequent mutex_unlock() dereferences a freed object. This is a use-after-free. Fix this by caching map and md before kref_put(), clearing req->map while holding buf_mutex, and using the cached md for mutex unlocking. The bug is reachable from userspace via the RapidIO mport character device interface. Link: https://lore.kernel.org/20260723235220.588424-1-james010kim@gmail.com Fixes: e8de370188d0 ("rapidio: add mport char device driver") Signed-off-by: James Kim Reviewed-by: Dan Carpenter Cc: Alexandre Bounine Cc: Greg Kroah-Hartman Cc: Matt Porter Cc: Signed-off-by: Andrew Morton Signed-off-by: Greg Kroah-Hartman --- drivers/rapidio/devices/rio_mport_cdev.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) --- a/drivers/rapidio/devices/rio_mport_cdev.c +++ b/drivers/rapidio/devices/rio_mport_cdev.c @@ -582,9 +582,13 @@ static void dma_req_free(struct kref *re } if (req->map) { - mutex_lock(&req->map->md->buf_mutex); - kref_put(&req->map->ref, mport_release_mapping); - mutex_unlock(&req->map->md->buf_mutex); + struct rio_mport_mapping *map = req->map; + struct mport_dev *md = map->md; + + mutex_lock(&md->buf_mutex); + req->map = NULL; + kref_put(&map->ref, mport_release_mapping); + mutex_unlock(&md->buf_mutex); } kref_put(&priv->dma_ref, mport_release_dma);