From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EE3A37F8D7; Sat, 12 Sep 2026 19:21:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789240869; cv=none; b=Oavs0lL5slzU3e20fQ6emT05/Osbz0y89NxGO+BHa1dwtppO2xf+jPyl+OThjRcCEpmeZkI/QpJ2B+mm4dkKZdcgECNRRMgDdML/wifKm/2Hg+LRaofvUX/r4wjDncaWJ79rQrU5b967oY/KduuSPN3gsQr+1C3Cw3bT75BFKwA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789240869; c=relaxed/simple; bh=1tTqnLM8hCcSHg5wzsl5L/kmcCgeNgIfGgbhy3JQZVY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mPgIhasdwxldKwS+7Sa6tBY7jQ8sJv8eiRxpH2WRXhnrX+5EYIKvrxWB3vAj4KMCG2QFUyOVE/tloyuRuYTRi0cxaBY4mQyqTKoPV2Y48LyAmKBB2lSNRJuOlxXR4qX2ZXoMfPv3SHWVgnO8sXBkYgSY/gaTMLBUQ3pVpjOuNL4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=H6cWViV2; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="H6cWViV2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A8B61F000FF; Sat, 12 Sep 2026 19:21:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=korg; t=1789240865; bh=u9cl+8FQvYaThZfPnZz1qEqtozrpp1XI8h9RhHyg7GA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=H6cWViV2BjvcPR1VrDFjuNnjo5iGldjGl0ZqHi2GKv9UWhn/C5ysx8ILM2YeEAZLa y7PlKZD71F8/2EFQdowQkfDV0XtZ20jExKF9b6q1eNolXY1jkcdh+ANHtPsOCfbt3T itOsPBUECJh/BlGxdVVM5SvRt8rh9WJkj6iCWuuc= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Daisuke Matsuda , Xu Yilun , Xu Yilun Subject: [PATCH 5.10 020/798] fpga: altera-cvp: Avoid out-of-bounds read in trailing byte write Date: Sat, 12 Sep 2026 08:54:08 +0200 Message-ID: <20260912065517.423192443@linuxfoundation.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260912065516.948645775@linuxfoundation.org> References: <20260912065516.948645775@linuxfoundation.org> User-Agent: quilt/0.69 X-stable: review X-Patchwork-Hint: ignore Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Daisuke Matsuda commit 9da70a43b5fea60d758137f7f0ccfe19356cb5bb upstream. The trailing byte path in altera_cvp_send_block() dereferences a u32 pointer even when only 1-3 bytes remain in the input buffer. If the buffer ends at a page or scatterlist boundary, this can read past the valid image data and fault. Copy the remaining bytes into a zero-initialized u32 before writing the final word so only valid bytes are read from the input buffer. Fixes: 34d1dc17ce97 ("fpga manager: Add Altera CvP driver") Cc: stable@vger.kernel.org Signed-off-by: Daisuke Matsuda Reviewed-by: Xu Yilun Link: https://lore.kernel.org/r/20260723081912.74082-1-dskmtsd@gmail.com Signed-off-by: Xu Yilun Signed-off-by: Greg Kroah-Hartman --- drivers/fpga/altera-cvp.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) --- a/drivers/fpga/altera-cvp.c +++ b/drivers/fpga/altera-cvp.c @@ -16,6 +16,7 @@ #include #include #include +#include #define CVP_BAR 0 /* BAR used for data transfer in memory mode */ #define CVP_DUMMY_WR 244 /* dummy writes to clear CvP state machine */ @@ -265,7 +266,7 @@ static int altera_cvp_v2_wait_for_credit static int altera_cvp_send_block(struct altera_cvp_conf *conf, const u32 *data, size_t len) { - u32 mask, words = len / sizeof(u32); + u32 words = len / sizeof(u32); int i, remainder; for (i = 0; i < words; i++) @@ -274,9 +275,10 @@ static int altera_cvp_send_block(struct /* write up to 3 trailing bytes, if any */ remainder = len % sizeof(u32); if (remainder) { - mask = BIT(remainder * 8) - 1; - if (mask) - conf->write_data(conf, *data & mask); + u32 word = 0; + + memcpy(&word, data, remainder); + conf->write_data(conf, word); } return 0;